Adding lake maker

[ShanSunNOAA]

Generating lake fraction and depth on the FV3 grid and adding them to oro_data. This commit references issue #111.

[GeorgeGayno-NOAA]

@shansun6 The addition of lakes should be a part of the grid generation process, not a stand-alone process. The main grid driver script is ./fv3gfs_driver_grid.sh. It is called by machine-specific batch scripts in ./driver_scripts.

[ShanSunNOAA]

Hi George, I agree that it is a good idea to include the lake maker as a part of the existing process. Between the 2 existing ones: fv3gfs_make_orog.sh fv3gfs_make_grid.sh does the lake maker fit better as a part of fv3gfs_make_orog.sh than fv3gfs_make_grid.sh, as both "fv3gfs_make_orog.sh" and lake maker deal with wet and dry surface types and complement each other? Currently, the raw lake data that are needed by the lake maker are located at /scratch1/BMC/gsd-fv3-dev/data_others/lake_rawdata/ GlobalLakeDepth.dat GlobalLakeDepth.txt GlobalLakeStatus.dat GlobalLakeStatus.txt do you plan to move them together with the raw oro data? If so, could you let us know the path on hera so we can update the path in the code to be committed? Thanks, Shan

…

On Tue, Jun 9, 2020 at 8:30 AM GeorgeGayno-NOAA ***@***.***> wrote: @shansun6 <https://github.com/shansun6> The addition of lakes should be a part of the grid generation process, not a stand-alone process. The main grid driver script is ./fv3gfs_driver_grid.sh. It is called by machine-specific batch scripts in ./driver_scripts. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALORMVT7JDYQRPDRDP5K55LRVZBP3ANCNFSM4NZAXIXQ> .

[GeorgeGayno-NOAA]

I will speak with Kate and Jun about saving the raw lake data somewhere.

[GeorgeGayno-NOAA]

Can you add the lake maker step at the bottom of "fv3gfs_make_orog.sh"? It will need to be an option.

[ShanSunNOAA]

Hi George, Thanks for helping with the relocation of the raw lake data. As for an option, do you mean adding one more argument, blue before, to fv3gfs_make_orog.sh? $ fv3gfs_make_orog.sh resolution tile grid_dir out_dir script_dir hist_dir do_lake TMPDIR If yes, then we will add the lake maker at the end of fv3gfs_make_orog.sh, something like: if do_lake, then "... generate lake_frac and add to orodata ..." end if Could you confirm that I understand you correctly? Thanks, Shan

…

On Wed, Jun 10, 2020 at 11:50 AM GeorgeGayno-NOAA ***@***.***> wrote: Can you add the lake maker step at the bottom of "fv3gfs_make_orog.sh"? It will need to be an option. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALORMVVGZOI6Z4TO57ZYAB3RV7BXNANCNFSM4NZAXIXQ> .

[GeorgeGayno-NOAA]

Yes, that is exactly what I meant. A flag such as 'do_lake' to exercise the lake code when true. Right now, I am not sure if all users will want lakes. This gives users a choice.