Enable 'receive_wait_time' configuration parameter for IronMqProvider #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IronMqProvider was not using 'receive_wait_time' configuration for long polling but it's supported since IronMQ 1.5.2 (iron-io/iron_mq_php@5e61539). Update 'receive_wait_time' default value for bc as users unaware of this configuration and using IronMQ would now notice a 3 second delay when polling for messages. May be 'iron_mq_php' dependency should be updated to >=1.5.2
|
The inspection completed: No new issues |
k-k
added a commit
that referenced
this pull request
Mar 23, 2015
Enable 'receive_wait_time' configuration parameter for IronMqProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IronMqProvider wasn't using
receive_wait_timeconfiguration for long polling but it's supported since IronMQ 1.5.2 (iron-io/iron_mq_php@5e61539).Update
receive_wait_timedefault value for bc as users unaware of this configuration and using IronMQ would now notice a 3 second delay when polling for messages.May be
iron_mq_phpdependency should be updated to >=1.5.2