feat: add support for default link protocol #5022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdbch
previously approved these changes
Apr 8, 2024
nperez0111
reviewed
Apr 9, 2024
|
Is there any information about when the feature is planned to be released? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Added the ability to specify a default protocol for the auto link features in the Link extension.
How did you accomplish your changes
Added a configurable
defaultProtocolsetting (the setting defaults to the previous default so there is no breaking change) that is then passed to linkifyjs to do its magic.How have you tested your changes
Added 4 tests to the Link mark demo testing the positive and negative cases. I also confirmed these new tests fail without the added setting.
How can we verify your changes
Open up the Link demo and type example.com. The href of the generated link should be https://example.com and the default in this demo is https. Then, type in http://example.com and confirm the href is still http://example.com.
Remarks
Checklist
Related issues
#5007