[Bug]: Wrong link on paste with hard break

[Ste35]

Affected Packages

extension-link

Version(s)

2.6.6

Bug Description

Hi, I'd like to report a possibile bug that occurs when pasting a link with a new line separated by an hard break (I hope it's not a duplicate!).

When coping and pasting together:

• a line with a link and
• a following line separated by an hard break (that is a br)

the pasted link "extends" to the first word of the following line and the link pasted is incorrect:

(in this case, the pasted link will be https://google.comThis)

The problem doesn't show up if the two lines are in different paragraphs:

You can also see the same issue in the Tiptap public demo: https://templates.tiptap.dev/

Is this an actual issue or am I missing something?
Thank you for your work!

Browser Used

Chrome

Code Example URL

https://stackblitz.com/edit/react-xqt1gu?file=src%2FApp.js

Expected Behavior

The copied link and the following line should be kept as in the original source.

Additional Context (Optional)

No response

Dependency Updates

• Yes, I've updated all my dependencies.

[iropolo]

Same issue.
Probably related to #5335

Reproduce issue on: https://templates.tiptap.dev/cqgCzK9LLr

Video:

Screen.Recording.2024-11-19.at.16.49.00.mov

[nperez0111]

It's likely this bit of code here which is trying to get all of the pasted content as a string to see what can be linked:

tiptap/packages/extension-link/src/helpers/pasteHandler.ts

Lines 24 to 29 in ff6e00a

	let textContent = ''
	slice.content.forEach(node => {
	textContent += node.textContent
	})

I would be happy to accept a contribution here. I think that all that needs to be done is to append a newline to each node.textContent added, so that when we look for links, it will not try to include the next word as the link.

I just don't have time to work on this at the moment & validate it. Would appreciate your help here @iropolo & @Ste35

[iropolo]

Huh I spend some time

I take a look into these files

->

tiptap/packages/extension-link/src/link.ts

Lines 346 to 349 in 86250c6

	addPasteRules() {
	return [
	markPasteRule({
	find: text => {

->

tiptap/packages/core/src/PasteRule.ts

Line 180 in 86250c6

export function pasteRulesPlugin(props: { editor: Editor; rules: PasteRule[] }): Plugin[] {

->

tiptap/packages/core/src/pasteRules/markPasteRule.ts

Lines 22 to 26 in f8961a9

	return new PasteRule({
	find: config.find,
	handler: ({
	state, range, match, pasteEvent,
	}) => {

Somewhere in markPasteRule seems like is messing with the nodes.

---

Process:

1. PasteRule
2. MarkPasteRule
3. PasteRule

At the beginning, the node looks like: (in pasteRule)

2 nodes. Second node with 2 content, link+text, separated.

Then, it starts the process of:

tiptap/packages/core/src/PasteRule.ts

Lines 122 to 124 in 86250c6

	state.doc.nodesBetween(from, to, (node, pos) => {
	if (!node.isTextblock || node.type.spec.code) {
	return

This will be run twice, 1 for each node:

These are the console.logs of text param:

tiptap/packages/extension-link/src/link.ts

Lines 346 to 349 in 86250c6

	addPasteRules() {
	return [
	markPasteRule({
	find: text => {

First return:

-> form:

Second return:

-> https://google.comMake

Finally the second node content seems to be unifed:
Result:

2 nodes.
Second node with 1 content unified.

---

I managed to ->

append a newline to each node.textContent added

I update

tiptap/packages/extension-link/src/helpers/pasteHandler.ts

Lines 25 to 29 in 86250c6

	let textContent = ''
	slice.content.forEach(node => {
	textContent += node.textContent
	})

To include a newline and this is the result (console.log of textContent value):

Before:

After:

Seems to looks ok in console.log() but the final result get transformed... seems the process go further.

Sorry if I get confused with the process or misunderstand it.
cc. @nperez0111

[alexvcasillas]

Hey @Ste35 we have identified the root cause of this issue and will be fixed with the next release of the extension-link package :)

[GiuseppeFantoni]

@alexvcasillas @nperez0111

I believe this problem has not been resolved

eu.-.Chat.-.Google.Chrome.2024-12-02.22-43-36.mp4

[alexvcasillas]

@alexvcasillas @nperez0111

I believe this problem has not been resolved

eu.-.Chat.-.Google.Chrome.2024-12-02.22-43-36.mp4

Hey @GiuseppeFantoni we haven't released the fix yet, we will do it soon as we're gathering more fixes so we batch some of them :)

We have upstreamed this to Linkify and they will fix it on their end so in the meantime we will have the fix applied on our end

[giuseppeagostini-hotmart]

@alexvcasillas Hi, Good morning, do we have any expectation of when this issue will be fixed?