Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax version constraint on ueberauth #71

Merged
merged 2 commits into from
Dec 3, 2022

Conversation

mhanberg
Copy link
Contributor

Currently you can't use the package with the latest version of
ueberauth. This relaxes that constraint and also updates the lockfile so
that the test is ran against the current version.

@mhanberg mhanberg requested a review from a team as a code owner November 21, 2022 02:12
@yordis
Copy link
Member

yordis commented Nov 21, 2022

Do we need to do anything to support ueberauth/ueberauth#136 ?

@mhanberg
Copy link
Contributor Author

Not sure

But I'll say in dev when I use override: true to get it to work, I did get a CSRF error from GitHub because I clicked the link on localhost instead of the ngrok link.

Not sure if GitHub did that or the app tho.

@doomspork
Copy link
Member

Howdy @mhanberg! Hope you are well. This change seems simple and clean enough to me @yordis, I think we should be good to merge.

Does look like CI is broken and we need to fix that first perhaps.

Currently you can't use the package with the latest version of
ueberauth. This relaxes that constraint and also updates the lockfile so
that the test is ran against the current version.
@yordis yordis force-pushed the mh/relax-version branch 2 times, most recently from 4f9c16e to d391504 Compare December 3, 2022 04:20
@yordis yordis merged commit d65d890 into ueberauth:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants