Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support private email address that are not in api responses #42

Merged
merged 1 commit into from
Nov 25, 2018

Conversation

antonydenyer
Copy link
Contributor

@antonydenyer antonydenyer commented Mar 13, 2018

Fixes #41

@mikatuo
Copy link

mikatuo commented Mar 15, 2018

Thanks for the fix!
IMHO it's better to return nil for private/not-available emails. It would be easier to check if the user has an email if it's not nil, rather than comparing with id+username@users.noreply.github.com. It makes sense to ask a user for a valid email in this case.

@antonydenyer
Copy link
Contributor Author

@mikatuo I think that has some knock-on effects for the rest of ueberauth.

@yordis yordis requested a review from doomspork June 28, 2018 17:56
@yordis
Copy link
Member

yordis commented Jun 28, 2018

@ueberauth/core could you take a look to this one

@doomspork doomspork merged commit c9e6ed0 into ueberauth:master Nov 25, 2018
@grrrisu
Copy link

grrrisu commented Aug 3, 2019

Hello
I just set the allow_private_emails flag, but had no effect. Until I realized, that this feature has never been released. Any intension to publish this?

@yordis
Copy link
Member

yordis commented Aug 27, 2019

@grrrisu Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

email is nil when authenticating using github app credentials
5 participants