Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(test): add coverage for empty chunks and Groq token usage handling #39

Merged
merged 1 commit into from
Nov 14, 2024
Merged

(test): add coverage for empty chunks and Groq token usage handling #39

merged 1 commit into from
Nov 14, 2024

Conversation

Kannav02
Copy link
Contributor

Fixes #38

The PR adds comprehensive test coverage for:

  1. Empty/undefined content chunks in stream responses
  2. Groq's specific token usage format handling in x_groq.usage

Proposed Changes

  • Add test case for handling empty content chunks in stream responses
  • Add test case for Groq-specific token usage format

@uday-rana uday-rana merged commit 8db307b into uday-rana:main Nov 14, 2024
2 checks passed
@uday-rana
Copy link
Owner

uday-rana commented Nov 14, 2024 •
edited
Loading

LGTM! Did you get a chance to try out the dev container?

@Kannav02
Copy link
Contributor Author

Yes i did, although I tested out the dev container after I was done making the changes lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test cases for empty chunks and Groq model token usage
2 participants
@Kannav02 @uday-rana