Fix implicit floating bool conversion #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang 3.9 warnings : |
|
Do NOT merge as-is since it is based on #753 |
| @@ -487,7 +487,7 @@ OPJ_BOOL opj_tcd_rateallocate( opj_tcd_t *tcd, | |||
| OPJ_FLOAT64 lo = min; | |||
| OPJ_FLOAT64 hi = max; | |||
| OPJ_BOOL success = OPJ_FALSE; | |||
| OPJ_UINT32 maxlen = tcd_tcp->rates[layno] ? opj_uint_min(((OPJ_UINT32) ceil(tcd_tcp->rates[layno])), len) : len; | |||
| OPJ_UINT32 maxlen = tcd_tcp->rates[layno] > 0 ? opj_uint_min(((OPJ_UINT32) ceil(tcd_tcp->rates[layno])), len) : len; | |||
There was a problem hiding this comment.
Wouldn't tcd_tcp->rates[layno] > 0.0f be more explicit ?
036d879 to
7117604
Compare
|
With or without the warning fixes : |
|
@julienmalik, could you refactor this PR following #753 merge Thanks |
…olean: 'OPJ_FLOAT32' (aka 'float') to '_Bool'
…olean: 'OPJ_FLOAT32' (aka 'float') to '_Bool'
7117604 to
e2d399f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang reports a number of implicit float-to-bool conversions.