Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate MQC_PERF_OPT #923

Closed
rouault opened this issue May 11, 2017 · 2 comments
Closed

Investigate MQC_PERF_OPT #923

rouault opened this issue May 11, 2017 · 2 comments
Assignees

Comments

@rouault
Copy link
Collaborator

rouault commented May 11, 2017

The MQC decoder has a MQC_PERF_OPT mode that is disabled currently. It was introduced originally per 627f484

Evaluate if it is functionally equivalent and performance impacts

@rouault rouault self-assigned this May 11, 2017
@rouault
Copy link
Collaborator Author

rouault commented May 12, 2017

@detonin @CharlesBuysschaertIntopix

The ASAN target of Travis tests showed that there was a memory issue that is now fixed per
rouault@755cc0f and now the tests are all good : https://travis-ci.org/rouault/openjpeg/builds/231321333

However I can't see performance improvements. With the basic list of tests, the timings are essentially the same with or without the optimization. But with the "testovani" suite, the total execution time in MQC_PERF_OPT mode is ~ 190 s, whereas with master it is ~ 167 s, so a clear performance regression. Probably because the optimization requires to do an extra pass on the codestream.

rouault added a commit that referenced this issue May 15, 2017
@rouault
Copy link
Collaborator Author

rouault commented May 15, 2017

Closing with removal of MQC_PERF_OPT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants