Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #587

Closed
elfring opened this issue Sep 13, 2015 · 5 comments
Closed

reserved identifier violation #587

elfring opened this issue Sep 13, 2015 · 5 comments
Labels

Comments

@elfring
Copy link

elfring commented Sep 13, 2015

I would like to point out that identifiers like "__FIX_H" and "__IMAGE_H" do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?

@elfring
Copy link
Author

elfring commented Jul 30, 2017

@rouault
Copy link
Collaborator

rouault commented Jul 30, 2017

Regarding thirdparty code, the issue should be first resolved upstream, and then openjpeg would resync with it

@elfring
Copy link
Author

elfring commented Jul 30, 2017

  • How do you think about to inform corresponding contributors for the other software components?
  • How much can you trigger further software improvements?

@rouault
Copy link
Collaborator

rouault commented Jul 30, 2017

How do you think about to inform corresponding contributors for the other software components?

Well, research about the other projects to know who their developers are, bug trackers, mailing list, etc. For example for libtiff : http://www.simplesystems.org/libtiff/

How much can you trigger further software improvements?

Sorry, I didn't understand what you meant.

Anyway thirdparty code is a bit second citizen (in my humble opinion), since for example Linux distributions will not compile it but rely on the external libraries

@elfring
Copy link
Author

elfring commented Jul 30, 2017

Well, research about …

I assumed that you might have a better contact to the other contributors already.

Sorry, I didn't understand what you meant.

  • Should this issue be reopened until the companion components will also be fixed anyhow?
  • Would you like to update any relationships with bundled software?

@detonin detonin added the bug label Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants