Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-semver-tags input argument #18

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

nwiltsie
Copy link
Member

Description

This closes #17 by adding a non-semver-tags argument. If that argument is given any value, the docker/metadata-action gets the additional docker tag format type=match,pattern=v(.*),group=1. That tag format will ensure that any git tag of the form vX will result in a docker tag of the form X.

I tested this with my trusty docker-internal-tests repository. When I had this workflow...

    steps:
      - uses: uclahs-cds/tool-Docker-action@dev
        with:
          non-semver-tags: true

... and tagged it as v0.0.5c, the workflow ran successfully and pushed the corresponding tag.

Note

As you can see I technically used the dev branch and not nwiltsie-arg-for-non-semver, but that's just to make future testing with that repository easier. The workflow logs show that it used 87e99e2.

When I removed the argument and tagged it as v0.0.5d, it failed with the error from #17.

Closes #17

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • I have set up or verified the main branch protection rule following the github standards before opening this pull request.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

@nwiltsie nwiltsie requested a review from a team August 13, 2024 22:35
Copy link
Collaborator

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nwiltsie nwiltsie merged commit 28a9544 into refactor-base Aug 14, 2024
5 checks passed
@nwiltsie nwiltsie deleted the nwiltsie-arg-for-non-semver branch August 14, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants