Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callVariant: variant bubble aligning issue #893

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Feb 12, 2025

…de merging with their outgoing nodes outside of the variant bubble to avoid complexity exploding

Description

Closes #892

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
  • All test cases passed locally.

…de merging with their outgoing nodes outside of the variant bubble to avoid complexity exploding
@zhuchcn
Copy link
Member Author

zhuchcn commented Feb 13, 2025

Fuzz test is good after 14,223 cases.

---------------------------------------------------------
|                  FUZZ TEST SUMMARY                    |
---------------------------------------------------------
|                       pass    fail    none    total   |
| ----------------------------------------------------- |
| snv                   3615    0       0       3615    |
| indel                 3623    0       0       3623    |
| comprehensive         6985    0       0       6985    |
| ----------------------------------------------------- |
| sum                   14223   0       0       14223   |
---------------------------------------------------------

@zhuchcn zhuchcn merged commit bc73cfd into main Feb 13, 2025
7 checks passed
@zhuchcn zhuchcn deleted the czhu-fix-call-variant branch February 13, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extremely long run-time for complex AltSplices
1 participant