Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename callNoncoding to callNovelORF #864

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Mar 27, 2024

Description

The internal source type "Noncoding" was also replaced with "NovelORF", as well as most of the occurrences of "Noncoding". Documentations were also updated.

Closes #863

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
  • All test cases passed locally.

@zhuchcn zhuchcn marked this pull request as ready for review March 27, 2024 18:02
@zhuchcn zhuchcn requested a review from lydiayliu March 27, 2024 18:02
zhuchcn and others added 3 commits March 28, 2024 15:37
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
@zhuchcn zhuchcn merged commit ad9348d into main Mar 28, 2024
2 checks passed
@zhuchcn zhuchcn deleted the czhu-rename-call-novel-orf branch March 28, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename callNoncoding to callNovelORF
2 participants