Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix callVariant with altSplice and intronic frameshift very close to the end of the subgraph #804

Merged
merged 5 commits into from
Aug 26, 2023

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Aug 24, 2023

Description

When aligning variants, I'm not treating any node that all outgoing nodes has a level lower than it as a subgraph end node.

Closes #803
Closes #810

Closes #...

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
  • All test cases passed locally.

…nt which is very closed to the end of the subgraph. #803
@zhuchcn zhuchcn requested a review from lydiayliu August 24, 2023 14:06
@zhuchcn zhuchcn merged commit 04fec22 into main Aug 26, 2023
@zhuchcn zhuchcn deleted the czhu-fix-call-variant branch August 26, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants