Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upper case for reference source for amino acid sequence #762

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Jul 5, 2023

Description

Sorry I missed this in the morning. I forgot that our amino acid sequence also has the function to infer reference source. It now also takes upper case values. So we should be good to go.

Closes #761

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
  • All test cases passed locally.

@zhuchcn zhuchcn mentioned this pull request Jul 5, 2023
6 tasks
@lydiayliu
Copy link
Collaborator

Is this ready for review?

@zhuchcn zhuchcn merged commit 5796597 into main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

style ENSEMBL is not supported
2 participants