Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Picard to 3.0.0 #24

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Update Picard to 3.0.0 #24

merged 1 commit into from
Mar 7, 2023

Conversation

bethneilsen
Copy link
Contributor

Checklist

Formatting

File Updates

  • I have ensured that the version number update follows the versioning standards.

  • I have updated the version number/dependencies and added my name to the maintainer list in the Dockerfile.

  • I have updated the version number/feature changes in the README.md.

  • I have updated the version number and added my name to the contributors list in the metadata.yaml.

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have drafted the new version release with any additions/changes and have linked the CHANGELOG.md in the release.

Docker Hub Auto Build Rules

  • I have created automated build rules following this page and I have not manually pushed this Docker image to the blcdsdockerregistry on Docker Hub.

Docker Image Testing

  • I have tested the Docker image with the docker run command as described below.

Test the Docker image with at least one sample. Verify the new Docker image works using:

docker run -u $(id -u):$(id -g) –w <working-directory> -v <directory-you-want-to-mount>:<how-you-want-to-mount-it-within-the-docker> --rm <docker-image-name> <command-to-the-docker-with-all-parameters>

My command:

docker run --rm -u $(id -u):$(id -g) picard:3.0.0 picard BuildBamIndex --version

Description

Closes # 23: Update Picard to 3.0.0

Testing Results

  • Case 1
    • sample:
    • input files:
    • config:
    • output:

@bethneilsen bethneilsen self-assigned this Mar 6, 2023
@bethneilsen bethneilsen requested a review from yashpatel6 March 6, 2023 03:32
Copy link
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You can merge the PR but hold off on making a release; this repo doesn't seem to have the auto-build action for Docker images so we'll want to add that before making a release (I'll create a separate issue with more details)

@bethneilsen bethneilsen merged commit 5d16bec into main Mar 7, 2023
@bethneilsen bethneilsen deleted the bneilsen-UpdatePicard branch March 7, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants