Add VSCode module to scaffolder #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98b6274 to
4cd643b
Compare
4cd643b to
6a2ce8b
Compare
dan-knight
reviewed
Oct 17, 2024
| @@ -35,7 +35,7 @@ class ScaffoldParsedArgs(NamedTuple): | |||
| name: Operation | |||
| endpoints: list[Operation] | |||
| template_type: Literal["basic", "openapi"] | |||
| modules: list[Literal["database", "test"]] | None | |||
| modules: list[str] | None | |||
There was a problem hiding this comment.
Is this change directly related to the VScode module? Do we lose anything by giving up the specificity of Literal["foo"]?
There was a problem hiding this comment.
It is more related to the ability to create more Scaffold modules without having to update the modules type or its values. We don't lose anything in practice; it has always been a list of strings, but now the specific values are unimportant to the type checker because they are dynamically set.
dan-knight
previously approved these changes
Oct 17, 2024
dan-knight
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a module to the scaffolder for users working with VSCode. Currently this just adds a launch.json with a couple debugger configurations.