Rename BL_Python to Ligare #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also accounts for case differences and separators, and other "BL <something>" names.
nwiltsie
approved these changes
Sep 24, 2024
Comment on lines
-5
to
+7
| from BL_Python.programming.patterns.dependency_injection import ( | ||
| BatchModule, | ||
| LoggerModule, | ||
| ) | ||
| from BL_Python.programming.str import get_random_str | ||
| from injector import Injector | ||
| from Ligare.programming.patterns.dependency_injection import BatchModule, LoggerModule | ||
| from Ligare.programming.str import get_random_str |
There was a problem hiding this comment.
Really, ruff? The line becomes 3 characters shorter and it therefore has to be reflowed?
There was a problem hiding this comment.
Snark aside, it was hugely helpful to do the reformatting in a different commit - awesome job.
There was a problem hiding this comment.
That's how it do be when only the tools have opinions.
| argv: list[str] | None = None, | ||
| log_level: int | str | None = None, | ||
| allow_overwrite: bool | None = None, | ||
| ) -> None: | ||
| """ | ||
| A method to support the `bl-alembic` command, which replaces `alembic. | ||
| A method to support the `ligare-alembic` command, which replaces `alembic`. |
There was a problem hiding this comment.
This entire PR was worth it to catch this typo.
There was a problem hiding this comment.
I'll open a second PR for just the typo. ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://github.com/uclahs-cds/group-CDS-owners/issues/111, BL_Python will be renamed to Ligare. This PR contains replacement values for strings matching (case-insensitive)
BL_Python,BL-Python,BL_Alembic,BL-Alembic,BLAlembic. These replacements include file names, directory names, variables, imports, strings, modules, configurations, etc. There should be no remaining references toBL.*in this PR (this regex isn't accurate, but close enough).