starts automated accessibility steps: loads @axe-core/react
on next dev
, enables eslint-plugin-jsx-a11y
on strict
#245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a couple of things:
eslint-plugin-jsx-a11y
, and turns it on withstrict
mode<label>
element, which is a valid concern. reworking it involves changing the DOM structure of the navbar, which in turn breaks the CSS - I'd like to table fixing this until we rework the navbar<Link><a></a></Link>
pattern, which is realistically a false-positive. Unfortunately, there's no great solution to this, and as such I've temporarily disabled the rule for<Link>
; see the comments in the eslint config for more info@axe-core/react
, which logs accessibility issues to the console in devSomething that's still left to be desired is to get aXe's level of accessibility specificity, but getting it as a CI action (like
eslint-plugin-jsx-a11y
) - will figure that out soon!Part of #218.