Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next level warning #61

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Next level warning #61

wants to merge 7 commits into from

Conversation

celebilaw
Copy link
Contributor

No description provided.

@Nhamakami7 Nhamakami7 self-requested a review April 10, 2022 01:14
@Nhamakami7
Copy link
Contributor

Hey Celebi I'm getting two errors that about code that is defined but never used:

let incrLevel;

if (!props.skippedWarning)
{
incrLevel =
}
else
{
incrLevel = <Link to={/level/${nextLevelNum}} onClick={props.levelChange}>
{" "}
{" "}

}

function toggle() {
props.toggle();
props.showWarning();
}

Could u lmk what the purpose of this code is just to be safe? I did test the code though and it does work. It's just that merging is blocked until we remove these unused variables.

@celebilaw
Copy link
Contributor Author

I think your merge removed some code, i'll try to fix it and let you know

@celebilaw
Copy link
Contributor Author

I merged master into the branch and fixed the merge conflicts.

@Nhamakami7
Copy link
Contributor

Tysm Celebi! And sorry for messing up your code, I'll check it and then merge

Copy link
Contributor

@Nhamakami7 Nhamakami7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Celebi, these changes look great! Sorry for the late review of your pull reqeust.

@Nhamakami7
Copy link
Contributor

Actually wait, I see that pressing the 'level tutorial' button no longer hides the level tutorial. I'm going to try to fix this real quick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants