Add new follow task #15
Conversation
MICH3LL3D
commented
Oct 11, 2024
- created a new following task
- added appropriate steps in tasks.yaml
- changed one line in wpt_env file (destination reached)
- ignore all the right turn changes
There was a problem hiding this comment.
Thank you for implementing the new CarDreamer task carla_follow. This is awesome! Left a few comments to be addressed before we merge the PR into the main branch, including log and temporary files to be cleaned up, readability issues, and changes that might affect other tasks. Feel free to let Hanchu or me know if you got any blockers and questions. We appreciate your contribution :)
24.1
Outdated
There was a problem hiding this comment.
the file is an empty pip log and can be removed
bin/tabulate
Outdated
| @@ -0,0 +1,8 @@ | |||
| #!/home/dongx/miniconda3/envs/cardreamer/bin/python | |||
There was a problem hiding this comment.
seems the script is not needed here. and the header contains a local path
There was a problem hiding this comment.
pyc files should be filtered out by gitignore
car_dreamer/carla_follow_env.py
Outdated
| max_num_of_directions = len(self._config.lane_start_points) | ||
| if self._config.direction == max_num_of_directions: | ||
| self.random_num = random.randint(0, max_num_of_directions - 1) # random path | ||
| elif self._config.direction >= 0 and self._config.direction < max_num_of_directions: |
There was a problem hiding this comment.
it seems that each direction values corresponds to specific meanings. it would be more readable to have enum constants defined in the utils
car_dreamer/carla_wpt_env.py
Outdated
| @@ -131,7 +131,8 @@ def reward(self): | |||
| return total_reward, info | |||
|
|
|||
| def is_destination_reached(self): | |||
| return len(self.waypoints) <= 3 | |||
| # return len(self.waypoints) <= 3 | |||
There was a problem hiding this comment.
wpt env is a base class that supports multiple different tasks like follow, right turn, left turn, and more. wondering if the change does not affect other tasks
There was a problem hiding this comment.
This is fantastic!! Thank you for the contributions!! Just left a few comments to be addressed before we merge the changes.