Skip to content

Commit

Permalink
NA Removed from Otter Grade CSV tests
Browse files Browse the repository at this point in the history
  • Loading branch information
sean-morris committed Jul 22, 2024
1 parent 7cc78bf commit 0192549
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions test/test_grade/test_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ def test_timeout_some_notebooks_finish():
containers = 5,
timeout = grade_timeout,
)
df_test = pd.read_csv("test/final_grades.csv", na_values='--')
assert pd.isna(df_test.iloc[0]["grading_status"])
df_test = pd.read_csv("test/final_grades.csv")
assert df_test.iloc[0]["grading_status"] == "--"
assert df_test.iloc[1]["grading_status"] == "Completed"
pattern = rf"Executing '[\w.\/-]*test\/test_grade\/files\/timeout\/1min\.ipynb' in docker container timed out in {grade_timeout} seconds"
assert re.match(pattern, df_test.iloc[2]["grading_status"]) is not None
Expand All @@ -112,7 +112,7 @@ def test_timeout_no_notebooks_finish():
containers = 5,
timeout = grade_timeout,
)
df_test = pd.read_csv("test/final_grades.csv", na_values='--')
df_test = pd.read_csv("test/final_grades.csv")
pattern1min = rf"Executing '[\w.\/-]*test\/test_grade\/files\/timeout\/1min\.ipynb' in docker container timed out in {grade_timeout} seconds"
pattern10s = rf"Executing '[\w.\/-]*test\/test_grade\/files\/timeout\/10s\.ipynb' in docker container timed out in {grade_timeout} seconds"
assert re.match(pattern10s, df_test.iloc[0]["grading_status"]) is not None
Expand All @@ -135,7 +135,7 @@ def test_network(expected_points):
no_network = True,
)

df_test = pd.read_csv("test/final_grades.csv", na_values='--')
df_test = pd.read_csv("test/final_grades.csv")

# sort by filename
df_test = df_test.sort_values("file").reset_index(drop=True)
Expand Down Expand Up @@ -164,7 +164,7 @@ def test_notebooks_with_pdfs(expected_points):
)

# read the output and expected output
df_test = pd.read_csv("test/final_grades.csv", na_values='--')
df_test = pd.read_csv("test/final_grades.csv")

# sort by filename
df_test = df_test.sort_values("file").reset_index(drop=True)
Expand Down

0 comments on commit 0192549

Please sign in to comment.