Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch parallel make #386

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Patch parallel make #386

merged 2 commits into from
Jan 22, 2020

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Jan 21, 2020

Occasionally, parallel make will silently ignore source file changes. See #377 and https://stackoverflow.com/questions/19822435/multiple-targets-from-one-recipe-and-parallel-execution/. This attempts to address this issue by adding a touch to the targets depending on the INTERMEDIATE value.

This was tested by doing make -j32 on the config./system listed in #377.

Fixes #377

@abejgonzalez abejgonzalez force-pushed the parallel-makefile-fixes branch from d387e9b to 9444fae Compare January 21, 2020 19:43
@abejgonzalez
Copy link
Contributor Author

Note: make 4.3 now supports the group target operator (&:) that is much more elegant. So when we enforce make >= 4.3 we can update this.

https://www.gnu.org/software/make/manual/html_node/Multiple-Targets.html

Copy link
Contributor

@jwright6323 jwright6323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinschmidt
Copy link
Contributor

Since make 4.3 is so new we should probably wait a while, probably until its in most package managers. If we ask our users to build lots of software from scratch they will get annoyed.

@abejgonzalez
Copy link
Contributor Author

Since make 4.3 is so new we should probably wait a while, probably until its in most package managers. If we ask our users to build lots of software from scratch they will get annoyed.

I agree. This PR should fix the issue in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants