-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch parallel make #386
Patch parallel make #386
Conversation
d387e9b
to
9444fae
Compare
Note: https://www.gnu.org/software/make/manual/html_node/Multiple-Targets.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since make 4.3 is so new we should probably wait a while, probably until its in most package managers. If we ask our users to build lots of software from scratch they will get annoyed. |
I agree. This PR should fix the issue in the meantime. |
Occasionally, parallel
make
will silently ignore source file changes. See #377 and https://stackoverflow.com/questions/19822435/multiple-targets-from-one-recipe-and-parallel-execution/. This attempts to address this issue by adding atouch
to the targets depending on theINTERMEDIATE
value.This was tested by doing
make -j32
on the config./system listed in #377.Fixes #377