Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UART and UARTAdapter to all configs #348

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Add UART and UARTAdapter to all configs #348

merged 2 commits into from
Jan 16, 2020

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Nov 25, 2019 •
edited
Loading

This PR adds a UART to all systems and adds a UARTAdapter in the TestHarness to talk to the UART.

Things to do:

  • Add UART to all configurations

@abejgonzalez abejgonzalez self-assigned this Nov 25, 2019
@abejgonzalez abejgonzalez requested review from colinschmidt, jerryz123 and sagark and removed request for colinschmidt November 27, 2019 01:10
@abejgonzalez abejgonzalez marked this pull request as ready for review November 27, 2019 01:11
@colinschmidt
Copy link
Contributor

Does this affect simulation speed?

@abejgonzalez
Copy link
Contributor Author

abejgonzalez commented Nov 28, 2019 •
edited
Loading

Yes. But I don't think by much if you are not running code that outputs to the UART. I haven't gotten an exact number though.

@abejgonzalez
Copy link
Contributor Author

@colinschmidt Do you want me to check something specifically?

@abejgonzalez
Copy link
Contributor Author

Note: This works with Linux boot in simulation with baudrate 115200 on the adapter.

colinschmidt
colinschmidt approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there some place in the docs where we should now mention what this config class does?

@abejgonzalez
Copy link
Contributor Author

LGTM. Is there some place in the docs where we should now mention what this config class does?

I just added a quick section on the adapter in the documentation. I can add more later if necessary.

@abejgonzalez abejgonzalez merged commit 9e2726a into dev Jan 16, 2020
@abejgonzalez abejgonzalez deleted the add-uart branch January 16, 2020 19:33
@jerryz123 jerryz123 mentioned this pull request Jan 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinschmidt colinschmidt colinschmidt approved these changes

@jerryz123 jerryz123 Awaiting requested review from jerryz123

@sagark sagark Awaiting requested review from sagark

@davidbiancolin davidbiancolin Awaiting requested review from davidbiancolin

Assignees

@abejgonzalez abejgonzalez

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abejgonzalez @colinschmidt