-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements and fixes #1420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a SpikeUltraFastConfig Linux boot test with RoCC instructions in CI just to ensure that things work properly.
Unfortunately I wasn't able to speed-up SpikeUltraFast fast enough to get it to chew through user code fast enough for CI. |
Can we just add a simple test of something that just does a single user space RoCC instruction and finishes? Like build Gemmini Spike model and just do a Gemmini TLB flush. |
I'll try something out |
Even after 30 minutes, the SpikeUltraFast has not made its way through init. More work needs to be done to improve its performance before we can have full boot-poweroff CI on it, unfortunately. |
We need to merge this while rc-blocks is failing because the fix was squash-merged into rc-blocks. #1411 will fix this. |
@abejgonzalez I say we go for merge on this, #1411 is basically ready, and that will fix some of the commit-on-master checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
TODO:
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?