Don't initialize nvdla-workload with init-submodules #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvdla-workload is very large, results in long init times
2ac84ec to
888abc3
Compare
abejgonzalez
requested changes
Dec 17, 2021
There was a problem hiding this comment.
Can you add some documentation to https://chipyard.readthedocs.io/en/dev/Software/index.html to indicate that there is a software/ dir and that you need to initialize it to use it?
| set -o pipefail | ||
|
|
||
| # Enable submodule update for software submodules | ||
| git config --unset submodule.software/nvdla-workload.update || : |
There was a problem hiding this comment.
Shouldn't this be git config --local --unset like what the init-submodules.sh script does?
There was a problem hiding this comment.
There was a problem hiding this comment.
I believe the --local flag is default.
These values are specific to that single repository, and represent passing the --local option to git config. If you don’t specify which level you want to work with, this is the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nvdla-workload is very large, results in long init times. Make users initialize this explicitly (like we do with gemmini-software)
Type of change: other enhancement
Impact: software change
Release Notes
NVDLA-workload submodule is not longer initialized with init-submodules script