Force FIRRTL 1.4.1 #1052
Merged
Force FIRRTL 1.4.1 #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: https://github.com/firesim/firesim/pull/887/files firesim/firesim#888
Type of change: bug fix
Impact: other
Release Notes
Modified from the equivalent FireSim PR:
Unfortunately, our firrtl-dependency overriding in chipyard's build.sbt has a hole wherein treadle pulls in a 1.5-SNAPSHOT from maven instead of our desired version of 1.4.1. Recently, a slew of deprecated APIs were removed in the 1.5-SNAPSHOT recently, leading treadle compilation to fail. As a result, Chipyard master and dev are broken.
Workaround this problem by specifying a FIRRTL version through the java system properties, which treadle will pick up to override the 1.5-SNAPSHOT default. We could do Chisel too.
The right solution to this (IMO) is to just use published dependencies for the big 5 instead of trying to build from source.
This will need to be back-ported to master.