Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add define for MAKE variable #1021

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Add define for MAKE variable #1021

merged 1 commit into from
Nov 1, 2021

Conversation

quyleanh
Copy link
Contributor

Currently there is no define for MAKE. Running script always throws obsolete make version; need GNU make 4.x or later error.

This config is from build-util.sh script

Related issue:

Type of change: bug fix

Impact: rtl change | software change | unknown | other

Release Notes

Currently there is no define for MAKE. Running script always throws `obsolete make version; need GNU make 4.x or later` error.

This config is from [`build-util.sh` script](https://github.com/ucb-bar/chipyard/blob/9d055fdac638ab90735cbde42fd2d86355eb260b/scripts/build-util.sh#L17-L19)
@abejgonzalez
Copy link
Contributor

Can you target this change to the dev branch then I can run CI on it to check it doesn't break things?

@jerryz123 jerryz123 changed the base branch from master to dev October 26, 2021 00:25
@abejgonzalez
Copy link
Contributor

@Mergifyio copy quyleanh_patch_1

@mergify
Copy link

mergify bot commented Oct 27, 2021

copy quyleanh_patch_1

❌ No copy have been created

  • Copy to branch quyleanh_patch_1 failed: Branch not found

@abejgonzalez
Copy link
Contributor

@Mergifyio copy dev

@mergify
Copy link

mergify bot commented Oct 27, 2021

copy dev

✅ Pull request copies have been created

@abejgonzalez abejgonzalez self-requested a review November 1, 2021 21:49
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Passes CI in #1025

@abejgonzalez abejgonzalez merged commit 15a6b9f into ucb-bar:dev Nov 1, 2021
@quyleanh quyleanh deleted the patch-1 branch November 2, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants