Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

Update to chisel 3.2.x #75

Merged
merged 4 commits into from
Feb 26, 2020
Merged

Update to chisel 3.2.x #75

merged 4 commits into from
Feb 26, 2020

Conversation

colinschmidt
Copy link
Contributor

Copy link
Collaborator

@jwright6323 jwright6323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing really sticks out; I posted a few questions, and I assume we're eventually going to deprecate the pads transform stuff?

mem_0_3.clk <= clk
mem_0_3.addr <= addr
node dout_0_3 = bits(mem_0_3.dout, 31, 0)
mem_0_3.din <= bits(din, 127, 96)
mem_0_3.write_en <= and(and(write_en, UInt<1>("h1")), UInt<1>("h1"))
mem_0_3.write_en <= and(and(and(write_en, UInt<1>("h1")), UInt<1>("h1")), UInt<1>("h1"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is due to a FIRRTL change, but where did this extra redundant and with 1 come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the and's are form #69 and some are from #70.
The width changes are form #74

}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems fine but is harder to review with all the whitespace removal :(

@colinschmidt colinschmidt merged commit 63d74bc into master Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants