Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pps 762 - ipaddress vulnerability #262

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Pps 762 - ipaddress vulnerability #262

merged 2 commits into from
Apr 3, 2024

Conversation

AlbertSnows
Copy link
Contributor

@AlbertSnows AlbertSnows commented Apr 2, 2024 •
edited
Loading

Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/issues/PPS-762?jql=ORDER%20BY%20created%20DESC

New Features

Breaking Changes

Bug Fixes

Improvements

Dependency updates

  • removing ipaddress from dependencies to resolve vulnerability issue

Deployment changes

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@AlbertSnows AlbertSnows marked this pull request as ready for review April 2, 2024 16:48
@AlbertSnows
Copy link
Contributor Author

tested on QA, etl runs successfully

@AlbertSnows AlbertSnows requested a review from k-burt-uch April 3, 2024 15:15
k-burt-uch
k-burt-uch approved these changes Apr 3, 2024
View reviewed changes
Copy link

@k-burt-uch k-burt-uch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. For context, ipaddress isn't used in the codebase and AJ tested this change in qa-dcp by running ETL and confirmed it was successful.

@thanh-nguyen-dang I added you as a reviewer since you're the tube/ETL expert - is there anything else AJ should test before merging?

@thanh-nguyen-dang
Copy link
Contributor

Looks good. For context, ipaddress isn't used in the codebase and AJ tested this change in qa-dcp by running ETL and confirmed it was successful.

@thanh-nguyen-dang I added you as a reviewer since you're the tube/ETL expert - is there anything else AJ should test before merging?

It looks good to me. Thanks @AlbertSnows

@AlbertSnows AlbertSnows merged commit da92f10 into master Apr 3, 2024
10 checks passed
@AlbertSnows AlbertSnows deleted the PPS-762 branch April 3, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-burt-uch k-burt-uch k-burt-uch approved these changes

@thanh-nguyen-dang thanh-nguyen-dang thanh-nguyen-dang approved these changes

Assignees
No one assigned
Labels
@requires-tube
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlbertSnows @thanh-nguyen-dang @k-burt-uch