Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aggregation count function #251

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix aggregation count function #251

merged 1 commit into from
Jan 29, 2024

Conversation

thanh-nguyen-dang
Copy link
Contributor

@thanh-nguyen-dang thanh-nguyen-dang commented Jan 29, 2024

Fix issue with missed count in MiDRC
There is a bug on count aggregation to filter the null entries.
This PR is to fix it

There is no error message, incorrect data

New Features

Breaking Changes

Deployment changes

Bug Fixes

  • Fixing bug on aggregated count to filter the null entries which result the incorrect data

Improvements

Dependency updates

Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@thanh-nguyen-dang thanh-nguyen-dang force-pushed the fix/agg-count branch 2 times, most recently from e14a4d3 to dd96cf7 Compare January 29, 2024 11:29
Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the PR description, and can we add a unit test for this issue?

Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will approve once unit test ticket is created and PR description is updated

@thanh-nguyen-dang thanh-nguyen-dang merged commit 61107fa into master Jan 29, 2024
7 checks passed
@thanh-nguyen-dang thanh-nguyen-dang deleted the fix/agg-count branch January 29, 2024 21:56
@paulineribeyre
Copy link
Contributor

unit test ticket https://ctds-planx.atlassian.net/browse/MIDRC-609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants