Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(job): use service account for dispatched jobs #29

Merged
merged 8 commits into from
Jul 24, 2020
Merged

feat(job): use service account for dispatched jobs #29

merged 8 commits into from
Jul 24, 2020

Conversation

giangbui
Copy link
Contributor

Breaking Changes

Use service account for jobs dispatched by the service. Support backward compatibility

@giangbui giangbui force-pushed the feat/job_sa branch 3 times, most recently from 22eb16f to cb5b193 Compare July 23, 2020 16:14
@giangbui giangbui force-pushed the feat/job_sa branch 3 times, most recently from e14e21f to 8197da5 Compare July 23, 2020 18:22
@giangbui giangbui force-pushed the feat/job_sa branch 6 times, most recently from 775441f to c851dcc Compare July 24, 2020 16:52
frickjack
frickjack approved these changes Jul 24, 2020
View reviewed changes
Copy link

@frickjack frickjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@giangbui giangbui merged commit 1ebb98b into master Jul 24, 2020
@giangbui giangbui deleted the feat/job_sa branch July 24, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frickjack frickjack frickjack approved these changes

Assignees
No one assigned
Labels
test-portal-dataUploadTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giangbui @frickjack