Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long type for big numbers #201

Merged
merged 6 commits into from
Jul 27, 2023
Merged

Fix long type for big numbers #201

merged 6 commits into from
Jul 27, 2023

Conversation

thanh-nguyen-dang
Copy link
Contributor

@thanh-nguyen-dang thanh-nguyen-dang commented Jun 29, 2023 •
edited
Loading

Jira Ticket: PXP-8590

Improvement

  • Since there are some file having file_size larger than the largest possible Int32 type in GraphQL, we need to extend it to use Float.

@thanh-nguyen-dang thanh-nguyen-dang changed the title fix(long): fix long type Fix long type for big numbers Jun 29, 2023
@github-actions
Copy link

github-actions bot commented Jun 29, 2023 •
edited
Loading

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@thanh-nguyen-dang thanh-nguyen-dang force-pushed the fix/long_type branch 2 times, most recently from 5907de3 to 8e6b539 Compare July 7, 2023 23:07
@thanh-nguyen-dang thanh-nguyen-dang force-pushed the fix/long_type branch 3 times, most recently from 4d8e7e7 to 5809d73 Compare July 12, 2023 15:15
@thanh-nguyen-dang thanh-nguyen-dang force-pushed the fix/long_type branch 8 times, most recently from b622a9a to 9a87e14 Compare July 21, 2023 09:52
paulineribeyre
paulineribeyre previously approved these changes Jul 26, 2023
View reviewed changes
@thanh-nguyen-dang thanh-nguyen-dang merged commit 23425c4 into master Jul 27, 2023
@thanh-nguyen-dang thanh-nguyen-dang deleted the fix/long_type branch July 27, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

Assignees
No one assigned
Labels
@requires-peregrine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thanh-nguyen-dang @paulineribeyre