Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle exceptions without 'message' attribute #178

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Handle exceptions without 'message' attribute #178

merged 1 commit into from
Aug 17, 2021

Conversation

paulineribeyre
Copy link
Contributor

@paulineribeyre paulineribeyre commented Aug 17, 2021 •
edited
Loading

Fix this error seen in IBD Prod Peregrine:

File "/peregrine/peregrine/resources/submission/graphql/__init__.py", line 126, in <listcomp>
    errors = [err.message for err in result.errors]
AttributeError: 'Exception' object has no attribute 'message'

relates to uc-cdis/pidgin#40

Bug Fixes

  • Handle exceptions without 'message' attribute

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@paulineribeyre paulineribeyre mentioned this pull request Aug 17, 2021
Merged
@paulineribeyre paulineribeyre requested a review from nss10 August 17, 2021 19:36
nss10
nss10 approved these changes Aug 17, 2021
View reviewed changes
Copy link

@nss10 nss10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulineribeyre paulineribeyre merged commit 95de251 into master Aug 17, 2021
@paulineribeyre paulineribeyre deleted the fix/err-message branch August 17, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nss10 nss10 nss10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulineribeyre @nss10