-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HP-1044 Feat/aggmds vlmd #90
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
MichaelLukowski
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I don't see any issues
jmontmaxwell
approved these changes
Feb 9, 2023
This was referenced Mar 7, 2023
This was referenced Apr 11, 2023
Closed
Merged
This was referenced Apr 26, 2023
Updating Env chicagoland.pandemicresponsecommons.org - 2023.04 1682532240
uc-cdis/cdis-manifest#5995
Merged
This was referenced May 5, 2023
Merged
This was referenced Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: HP-1044
Add variable-level metadata (VLMD) support to AggMDS
Currently AggMDS can only pull in study-level metadata (SLMD)
All AggMDS endpoints should be backward-compatible except for the following:
/aggregate/metadata/guid/{guid}
and/aggregate/metadata/{name}
Perviously these 2 endpoint will only return SLMD
Now they will return both SLMD and VLMD (if exists) and their correspoiding parent, in the format of
New Features
AGG_MDS_DEFAULT_STUDY_DATA_FIELD
to MDS config to indicate the SLMD field name in AggMDS records, default togen3_discovery
AGG_MDS_DEFAULT_DATA_DICT_FIELD
to MDS config to indicate the VLMD field name in AggMDS records, if available, default toNone
data_dict_field
to AggMDS adatper config to indicate the VLMD field name in metadata that will be populated into AggMDS, this field is optionalBreaking Changes
/aggregate/metadata/guid/{guid}
has changed, please refer to the PR description and/or API docs for details/aggregate/metadata/{name}
has changed, please refer to the PR description and/or API docs for detailsDeployment changes