Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PXP-8853): Explain why MDS 404 might be ok in logs #34

Merged
merged 6 commits into from
Oct 21, 2021

Conversation

johnfrancismccann
Copy link
Contributor

Jira ticket

The indexs3client job was previously modified to support populating Metadata Service objects after running gen3-client upload ... with the --metadata option supplied. Because the job has no way of knowing whether or not --metadata was supplied, it always attempts to update an MDS object corresponding to the GUID parsed out of the job's input (an S3 url).

This means that after a user uploads a file without --metadata, MDS will return a 404 to the job for the attempted object update. The job doesn't fail because --metadata might not have been supplied, but it does log the 404, which has been a source of confusion (see ticket) for engineers.

This ticket aims to add information to the log message explaining why a 404 from MDS isn't necessarily a problem.

Improvements

  • Explain in logs why a 404 from MDS isn't necessarily a problem.

@johnfrancismccann johnfrancismccann merged commit 53deec6 into master Oct 21, 2021
@m0nhawk m0nhawk deleted the doc/explain-why-mds-404-might-be-ok-in-logs branch October 21, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants