(PXP-8853): Explain why MDS 404 might be ok in logs #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
The
indexs3client
job was previously modified to support populating Metadata Service objects after runninggen3-client upload ...
with the--metadata
option supplied. Because the job has no way of knowing whether or not--metadata
was supplied, it always attempts to update an MDS object corresponding to the GUID parsed out of the job's input (an S3 url).This means that after a user uploads a file without
--metadata
, MDS will return a 404 to the job for the attempted object update. The job doesn't fail because--metadata
might not have been supplied, but it does log the 404, which has been a source of confusion (see ticket) for engineers.This ticket aims to add information to the log message explaining why a 404 from MDS isn't necessarily a problem.
Improvements