Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run ECS launch in goroutine, and add local cluster paymodel #61

Merged
merged 22 commits into from
Apr 13, 2023
Merged

Run ECS launch in goroutine, and add local cluster paymodel #61

merged 22 commits into from
Apr 13, 2023

Conversation

jawadqur
Copy link
Contributor

@jawadqur jawadqur commented Mar 30, 2023 •
edited
Loading

Jira Ticket: PXP-xxxx

  • Remove this line if you've changed the title to (PXP-xxxx): <title>

New Features

  • Run ECS launch in a goroutine, but return 200 at once to prevent timeout issues.
  • Add in support for above_limit paymodels and general fixes for paymodels
  • Tear down Load Balancer Target group (It doesn't cost money, but sometimes the configuration of it can be out of sync so better to create a new one each time)

Breaking Changes

Bug Fixes

Improvements

  • Better logging when creating AWS resources, so it's easier to troubleshoot.

Dependency updates

Deployment changes

nss10
nss10 reviewed Apr 10, 2023
View reviewed changes
Copy link
Contributor

@nss10 nss10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I couldn't be of much help in reviewing code related to alb or Transitgateways but I did add my thoughts on the rest.

Awesome job Jawad!

hatchery/hatchery.go Show resolved Hide resolved
hatchery/hatchery.go Outdated Show resolved Hide resolved
hatchery/paymodels.go Show resolved Hide resolved
hatchery/paymodels.go Outdated Show resolved Hide resolved
hatchery/paymodels.go Outdated Show resolved Hide resolved
hatchery/paymodels.go Show resolved Hide resolved
hatchery/vpc.go Show resolved Hide resolved
hatchery/ecs.go Show resolved Hide resolved
@nss10 nss10 mentioned this pull request Apr 11, 2023
Merged
@jawadqur jawadqur changed the title Run ECS launch in goroutine, to prevent timeout issues Run ECS launch in goroutine, and add local cluster paymodel Apr 12, 2023
nss10
nss10 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@nss10 nss10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the new changes look good to me!

@aartivnkt aartivnkt mentioned this pull request Apr 13, 2023
Merged
@nss10 nss10 merged commit 9bcd8d1 into master Apr 13, 2023
@nss10 nss10 deleted the feat/ecs_goroutine branch April 13, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nss10 nss10 nss10 approved these changes

Assignees
No one assigned
Labels
test-apis-etlTest test-coremetadata-getCoremetadataTest test-portal-coremetadatapageTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jawadqur @nss10 @PlanXCyborg