Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tier config QA-IBD #2036

Merged
merged 4 commits into from
Jun 21, 2022
Merged

tier config QA-IBD #2036

merged 4 commits into from
Jun 21, 2022

Conversation

atharvar28
Copy link
Contributor

@atharvar28 atharvar28 requested a review from paulineribeyre June 1, 2022 16:09
@PlanXCyborg
Copy link
Contributor

qa-ibd.planx-pla.net

❌ etlMapping.yaml - gitops.json mismatch

  • Field error: Field [project_id] in explorerConfig.filters.tabs.fields not found in etlMapping
  • Field error: Field [project_id] in explorerConfig.table.fields not found in etlMapping
  • Field error: Field [project_id] in explorerConfig.table.fields not found in etlMapping
  • Field error: rowAccessor [project_id] not found in index with type project

@paulineribeyre paulineribeyre removed their request for review June 6, 2022 15:51
@paulineribeyre
Copy link
Contributor

not ready for review

@atharvar28 atharvar28 marked this pull request as draft June 16, 2022 15:25
@PlanXCyborg
Copy link
Contributor

qa-ibd.planx-pla.net

❌ etlMapping.yaml - gitops.json mismatch

  • Field error: Field [project_id] in explorerConfig.filters.tabs.fields not found in etlMapping
  • Field error: Field [project_id] in explorerConfig.table.fields not found in etlMapping
  • Field error: Field [project_id] in explorerConfig.table.fields not found in etlMapping
  • Field error: rowAccessor [project_id] not found in index with type project

@PlanXCyborg
Copy link
Contributor

qa-ibd.planx-pla.net

❌ etlMapping.yaml - gitops.json mismatch

  • Field error: Field [project_id] in explorerConfig.filters.tabs.fields not found in etlMapping
  • Field error: Field [project_id] in explorerConfig.table.fields not found in etlMapping
  • Field error: Field [project_id] in explorerConfig.table.fields not found in etlMapping
  • Field error: rowAccessor [project_id] not found in index with type project

1 similar comment
@PlanXCyborg
Copy link
Contributor

qa-ibd.planx-pla.net

❌ etlMapping.yaml - gitops.json mismatch

  • Field error: Field [project_id] in explorerConfig.filters.tabs.fields not found in etlMapping
  • Field error: Field [project_id] in explorerConfig.table.fields not found in etlMapping
  • Field error: Field [project_id] in explorerConfig.table.fields not found in etlMapping
  • Field error: rowAccessor [project_id] not found in index with type project

@atharvar28 atharvar28 marked this pull request as ready for review June 16, 2022 21:48
paulineribeyre
paulineribeyre reviewed Jun 16, 2022
View reviewed changes
qa-ibd.planx-pla.net/portal/gitops.json
@@ -243,6 +243,7 @@
],
"guppyConfig": {
"dataType": "participant",
"tierAccessLevel": "regular",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we need it in this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/uc-cdis/data-portal/blob/master/docs/portal_config.md?plain=1#L336

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also Mingfei confirmed it
https://cdis.slack.com/archives/CNAHGS3MZ/p1655131491082749?thread_ts=1655131112.282539&cid=CNAHGS3MZ

@paulineribeyre
Copy link
Contributor

still investigating why kube-setup-portal is breaking this

@atharvar28 atharvar28 merged commit f1464be into master Jun 21, 2022
@atharvar28 atharvar28 deleted the atharvar28-patch-2 branch June 21, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulineribeyre paulineribeyre Awaiting requested review from paulineribeyre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atharvar28 @PlanXCyborg @paulineribeyre