(PXP-7846): Visa refresh token expiration parameter #883
Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 10561
💛 - Coveralls |
fence/blueprints/login/ras.py
Outdated
|
|
||
| # User definied RAS refresh token expiration time | ||
| parsed_url = urllib.parse.parse_qs(flask.redirect_url) | ||
| if parsed_url.get("visa_refresh_exp"): |
There was a problem hiding this comment.
You used visa_refresh_exp, the ticket says ras_expires_at, and other Fence endpoints use expires_in.
I'd suggest expires_in for consistency, unless the name in the ticket is a hard requirement
There was a problem hiding this comment.
do you mean use visa_expires_in or just expires_in? If i do expires_in then wouldn't this affect the fence refresh token as well?
There was a problem hiding this comment.
i was suggesting just expires_in but i didn't look closely, if expires_in is already used in this endpoint, then maybe upstream_expires_in? 🤷♀️
There was a problem hiding this comment.
or refresh_token_expires_in, but i think visa_expires_in might be confusing?
There was a problem hiding this comment.
I was thinking the same as well. Maybe upstream_expires_in
There was a problem hiding this comment.
👍 update PR description :p
…nce into feat/ras_expiration_parameter
Co-authored-by: Pauline Ribeyre <ribeyre@uchicago.edu>
This was an ask from ISB-CGC. It's mostly for testing purposes. Basically #848 but for RAS or any other Visa provider we might have in the future.
New Features
upstream_expires_inparameter in the/authorizationendpoint to manually add refresh token expiration time.Bug Fixes