Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/delete with no urls #870

Merged
merged 14 commits into from
Feb 26, 2021
Merged

Conversation

mysterious-progression
Copy link
Contributor

https://ctds-planx.atlassian.net/browse/PXP-7389

No longer gives an error when attempting to delete records with no urls listed. Deletion proceeds as usual.

Bug Fixes

Fix bug caused by an empty url list when attempting to delete a record.

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@paulineribeyre
Copy link
Contributor

cc @mcannalte

@coveralls
Copy link

coveralls commented Feb 24, 2021

Pull Request Test Coverage Report for Build 10479

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 69.567%

Totals Coverage Status
Change from base Build 10464: 0.1%
Covered Lines: 5717
Relevant Lines: 8218

💛 - Coveralls

@mysterious-progression mysterious-progression merged commit b4ccb98 into master Feb 26, 2021
@mysterious-progression mysterious-progression deleted the fix/delete_with_no_urls branch February 26, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants