-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add support for soft delete user #1189
Conversation
0daf4fa
to
81aa35d
Compare
Please find the detailed integration test report here Please find the ci env pod logs here |
2286fd5
to
63fb947
Compare
81aa35d
to
8f8fdf7
Compare
f964c76
to
044b5e9
Compare
bffce5d
to
d47acbd
Compare
Please find the detailed integration test report here Please find the ci env pod logs here |
28573d1
to
b583a70
Compare
4922ae1
to
4ef61db
Compare
Pull Request Test Coverage Report for Build 11843671360Details
💛 - Coveralls |
Please find the detailed integration test report here Please find the ci env pod logs here |
4ef61db
to
baef648
Compare
@@ -78,7 +78,7 @@ def create_user(): | |||
|
|||
Returns a json object | |||
""" | |||
username = request.get_json().get("name", None) | |||
username = request.get_json().get("username", None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this in "create" and "update" is a breaking change, it's probably fine since it's not used, but let's state it under "breaking changes" in the PR description
Please find the detailed integration test report here Please find the ci env pod logs here |
6c20a56
to
21e7afa
Compare
Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
Comment on breaking changes: see also changes in bfd381f . Based on my code review (and partly on internal discussion that can be found in the JIRA ticket), the admin part does not seem to be used. So impact is likely none.
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/VADC-1357
New Features
Improvements
username
instead of a mix ofname
andusername
in the /admin/user endpoints.Breaking Changes
username
instead ofname
.