Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPE-891 Add ENABLE_VISA_UPDATE_CRON setting #1087

Merged
merged 2 commits into from
Apr 18, 2023
Merged

GPE-891 Add ENABLE_VISA_UPDATE_CRON setting #1087

merged 2 commits into from
Apr 18, 2023

Conversation

paulineribeyre
Copy link
Contributor

@paulineribeyre paulineribeyre commented Apr 14, 2023 •
edited by jira bot
Loading

Jira Ticket: GPE-891

Relates to uc-cdis/cloud-automation#2211

New Features

  • Add the ENABLE_VISA_UPDATE_CRON setting

Breaking Changes

  • The default value for the GLOBAL_PARSE_VISAS_ON_LOGIN setting is now False instead of None. By default, parsing visas on login is now disabled and the parse_visas parameter cannot be used

Bug Fixes

Improvements

Dependency updates

Deployment changes

  • Systems that use visas parsing must update their Fence configuration to set ENABLE_VISA_UPDATE_CRON to True and set GLOBAL_PARSE_VISAS_ON_LOGIN to either True or None

@coveralls
Copy link

coveralls commented Apr 14, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 13404

  • 4 of 8 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 74.504%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/config.py 1 2 50.0%
fence/blueprints/login/ras.py 3 6 50.0%
Totals Coverage Status
Change from base Build 13371: -0.03%
Covered Lines: 7139
Relevant Lines: 9582
💛 - Coveralls

@paulineribeyre paulineribeyre mentioned this pull request Apr 14, 2023
Merged
@paulineribeyre paulineribeyre changed the title Add ENABLE_VISA_UPDATE_CRON setting GPE-891 Add ENABLE_VISA_UPDATE_CRON setting Apr 14, 2023
@paulineribeyre
Copy link
Contributor Author

ignoring failing broken test-google-googleDataAccessTest tests

@paulineribeyre paulineribeyre merged commit a17003d into master Apr 18, 2023
@paulineribeyre paulineribeyre deleted the feat/ENABLE_VISA_UPDATE_CRON branch April 18, 2023 15:21
This was referenced Apr 21, 2023
Merged
Merged
Merged
This was referenced May 5, 2023
Merged
Merged
Closed
@github-actions github-actions bot mentioned this pull request May 5, 2023
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request May 5, 2023
Closed
This was referenced May 9, 2023
Merged
Merged
Closed
Closed
This was referenced May 18, 2023
Merged
Merged
Merged
Merged
This was referenced Jun 2, 2023
Merged
Merged
Merged
@github-actions github-actions bot mentioned this pull request Jun 12, 2023
Closed
This was referenced Jun 21, 2023
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this pull request Jul 6, 2023
Merged
This was referenced Jul 18, 2023
Merged
Merged
This was referenced Aug 15, 2023
Merged
Merged
@github-actions github-actions bot mentioned this pull request Oct 18, 2023
Merged
@github-actions github-actions bot mentioned this pull request Nov 2, 2023
Merged
This was referenced Dec 12, 2023
Merged
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avantol13 Avantol13 Avantol13 approved these changes

@BinamB BinamB Awaiting requested review from BinamB

Assignees
No one assigned
Labels
test-google-googleDataAccessTest setting label to retry specific feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulineribeyre @coveralls @Avantol13 @PlanXCyborg