-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/al2 updates #99
Feat/al2 updates #99
Conversation
pyproject.toml
Outdated
@@ -21,7 +21,7 @@ gdcdictionary = {git = "https://github.com/NCI-GDC/gdcdictionary.git", rev = "2. | |||
|
|||
[tool.poetry.dev-dependencies] | |||
pytest = "*" | |||
data-simulator = {git = "https://github.com/uc-cdis/data-simulator.git", branch = "update-branches"} | |||
data-simulator = {git = "https://github.com/uc-cdis/data-simulator.git", branch = "chore/use-absolute-path-in-imports"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to master
after the data-simulator PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to master
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all looking good!
The README file describes how to use the docker image for testing local copies of dictionaries.
To verify, you can replace
master
from quay with this branch or you can do a local docker build and use your tagged image.New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes