Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/al2 updates #99

Merged
merged 11 commits into from
Dec 6, 2024
Merged

Feat/al2 updates #99

merged 11 commits into from
Dec 6, 2024

Conversation

george42-ctds
Copy link
Contributor

The README file describes how to use the docker image for testing local copies of dictionaries.

To verify, you can replace master from quay with this branch or you can do a local docker build and use your tagged image.

New Features

Breaking Changes

Bug Fixes

  • Fix local dictionary testing done with the Docker image

Improvements

  • Update base images to AL2 in Dockerfile

Dependency updates

Deployment changes

pyproject.toml Outdated
@@ -21,7 +21,7 @@ gdcdictionary = {git = "https://github.com/NCI-GDC/gdcdictionary.git", rev = "2.

[tool.poetry.dev-dependencies]
pytest = "*"
data-simulator = {git = "https://github.com/uc-cdis/data-simulator.git", branch = "update-branches"}
data-simulator = {git = "https://github.com/uc-cdis/data-simulator.git", branch = "chore/use-absolute-path-in-imports"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to master after the data-simulator PR is merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to master

Copy link

github-actions bot commented Dec 4, 2024

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

Copy link
Contributor

@jacob50231 jacob50231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all looking good!

@jacob50231 jacob50231 merged commit f0db428 into master Dec 6, 2024
10 checks passed
@jacob50231 jacob50231 deleted the feat/al2-updates branch December 6, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants