-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/permissions PXP-4524 #610
Conversation
I'm still a bit of lost about the download button rendering logic. Would it be better if |
@mfshao See PR description. Doesn't make sense to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good to me. Just a small suggestion
066bf53
to
540c6ae
Compare
* and make configurable
This PR makes the profile page show authz info from fence or arborist or both or neither, depending on the config. Additionally it fixes the file page's download button. See details below.
For download button, here is why we are throwing out the Fence authz checks:
New Features
Breaking Changes