fix/HIV app and Guppy #558
Conversation
| @@ -38,6 +38,10 @@ class ExplorerFilter extends React.Component { | |||
| } | |||
| } | |||
| } | |||
| return null; | |||
There was a problem hiding this comment.
to address a warning found in console while testing using dev.html.
Warning: ExplorerFilter.getSnapshotBeforeUpdate(): A snapshot value (or null) must be returned. You have returned undefined.
| return null; | ||
| } | ||
|
|
||
| componentDidUpdate() { |
There was a problem hiding this comment.
to address a warning found in console while testing using dev.html.
Warning: ExplorerFilter: getSnapshotBeforeUpdate() should be used with componentDidUpdate(). This component defines getSnapshotBeforeUpdate() only.
|
deployed in https://qa-niaid.planx-pla.net |
hmmm... yeah it is deployed on QA-NIAID now |
| body: JSON.stringify({ | ||
| query: queryString, | ||
| variables: JSON.parse(variableString), |
There was a problem hiding this comment.
In the case where we use arranger, variableString will be undefined right? And I think that will lead to the error Uncaught SyntaxError: Unexpected token u in JSON at position 0
There was a problem hiding this comment.
nice catch! fixed in 1dd7906
…ta-portal into fix/hiv-app-and-guppy
Let NIAID's HIV app support Guppy
Please make sure to follow the DEV guidelines before asking for review.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes
is notop for filter guppy#45 (0.2.1+) if want to use Guppy for NIAID