PXD-1310 Fix/css refactor 3 #327
Conversation
407584f to
5551d4d
Compare
src/Submission/SubmitForm.less
Outdated
|
|
||
| .submit-form__label { | ||
| margin: 3px; | ||
| display:inline-block; |
There was a problem hiding this comment.
picky - spacing. going to add a csslinter soon! 🤪
src/Submission/SubmitForm.less
Outdated
|
|
||
| .submit-form__input-description { | ||
| font-size: 1rem; | ||
| display:inline-block; |
src/Submission/SubmitForm.less
Outdated
|
|
||
| .submit-form__input { | ||
| width: 400px; | ||
| height:40px; |
src/Submission/SubmitForm.less
Outdated
| } | ||
|
|
||
| .submit-form__sub-props { | ||
| margin-left:50px; |
src/Submission/SubmitForm.less
Outdated
| .submit-form__select { | ||
| width: 40%; | ||
| margin-right: 1em; | ||
| display:inline-block; |
| @@ -0,0 +1,11 @@ | |||
| .access-table .base-table__cell:nth-child(1), | |||
There was a problem hiding this comment.
can we just do a generic text-align: left ? I think there's only two columns
src/components/tables/KeyTable.less
Outdated
| @@ -0,0 +1,6 @@ | |||
| .key-table .base-table__cell:nth-child(1), | |||
There was a problem hiding this comment.
same here about text-align: left for all
| overflow: auto; | ||
| margin: 1em 0em; | ||
| text-align:center; | ||
| width:100%; |
There was a problem hiding this comment.
this line and line above - spacing
| width:100%; | ||
| } | ||
|
|
||
| .base-table__head { |
There was a problem hiding this comment.
I think this is the same as .base-table__foot
| } | ||
| </TRow> | ||
| ); | ||
| <tr className="base-table__row base-table__row--strip-color"> |
There was a problem hiding this comment.
think this should be .base-table__row--stripe-color
| @@ -0,0 +1,12 @@ | |||
| .transaction-log-table__status-bar { | |||
| font-size: 16px; | |||
| text-align: left; | |||
There was a problem hiding this comment.
This is only applying to Succeeded states:
| } | ||
|
|
||
| .transaction-log-table__status-bar--fail { | ||
| color: #ff2200; |
There was a problem hiding this comment.
Also it doesn't look like the color is being applied to the text
ffc8bb3 to
77a562f
Compare
3eabe8a to
b7c5d51
Compare
9bd530c to
78d01c4
Compare
src/Explorer/ExplorerTable.less
Outdated
| @@ -97,7 +97,6 @@ | |||
| } | |||
|
|
|||
| .explorer-table__table-data--foot-cell { | |||
There was a problem hiding this comment.
do we need this if it's empty?
src/Submission/AnyOfInput.jsx
Outdated
| return ( | ||
| <div> | ||
| <h6 className='submit-form__name'>{name}:</h6> | ||
| {required && <span className='submit-form__required-notification'> {'*'} </span>} |
There was a problem hiding this comment.
I think this className and the others in the file should be any-of-input__.... right?
| text-align: left; | ||
| } | ||
|
|
||
| // TBD: refactoring WIG |
There was a problem hiding this comment.
I'm not sure what this comment means
| @@ -28,11 +15,11 @@ class TransactionLogTable extends Component { | |||
| }; | |||
|
|
|||
| stateToColor = state => (state === 'SUCCEEDED' && | |||
| <StatusBar className='special-number'>{formatText(state)}</StatusBar>) | |||
| <div className='form-special-number transaction-log-table__status-bar'>{formatText(state)}</div>) | |||
There was a problem hiding this comment.
what is 'form-special-number' ? I thought it was just 'special-number'
There was a problem hiding this comment.
This should be 'form-special-number', spec confirmed, previous classname must be typo
There was a problem hiding this comment.
oh okay I didn't see form-special-number in our base.less 👍
No description provided.