PXD-1291 Make Arranger filters look like our spec #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abgeorge7
commented
Jul 31, 2018
•
- Modified the Arranger component to divide sections into tabs
- If tab configuration is provided in parameters.js, then it will be divided into tabs. Otherwise it will just be normal Arranger aggregation filters that look more our style.
- Overrode Arranger styles
…a-portal into feat/arranger-portal-on-page
abgeorge7
commented
Jul 31, 2018
| @@ -0,0 +1,77 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Same file as in my last PR, just moved to a new folder
thanh-nguyen-dang
previously requested changes
Jul 31, 2018
frickjack
reviewed
Jul 31, 2018
| <h4 className="data-explorer__filters-title">Filters</h4> | ||
| <AggregationTabs | ||
| filterConfig={this.props.arrangerConfig.filters} | ||
| {...this.props} |
There was a problem hiding this comment.
What happens if arrangerConfig is not defined or just {}?
src/Arranger/AggregationTabs.jsx
Outdated
| const tabs = []; | ||
| filterConfig.tabs.forEach((tab, i) => { | ||
| const tabAggs = aggs.filter(agg => tab.fields.includes(agg.field)); | ||
| tabs.push( |
There was a problem hiding this comment.
This should be aggs.find instead of aggs.filter to avoid case where same field appears in more than one tab by accident?
src/Arranger/AggregationTabs.jsx
Outdated
| } | ||
| />, | ||
| ); | ||
| }); |
There was a problem hiding this comment.
What happens to a field that is configured in arranger, but not registered in a tab?
There was a problem hiding this comment.
It would get left out I think - I will write a test for that
This was referenced Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.