Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add histogram for continuous covariates #1178

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Feat/add histogram for continuous covariates #1178

merged 1 commit into from
Dec 16, 2022

Conversation

pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Dec 16, 2022 •
edited
Loading

Jira Ticket: VADC-79

New Features

  • Added new histogram component that connects with cohort-middleware histogram endpoint
  • Small fix to Euler diagram storybook

Screenshot:

Screenshot 2022-12-16 at 12 24 55

@pieterlukasse pieterlukasse changed the base branch from master to feat/vadc_sprint25 December 16, 2022 11:26
@pieterlukasse
feat: basic histogram and storybook, including version that queries b…
c3d69ff 
…ackend

...using recharts library which is already part
of this portal.

Also fixed CohortsOverlapDiagram storybook
@pieterlukasse pieterlukasse force-pushed the feat/add_histogram_for_continuous_covariates branch from caf40ed to c3d69ff Compare December 16, 2022 11:32
jarvisraymond-uchicago
jarvisraymond-uchicago approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@jarvisraymond-uchicago jarvisraymond-uchicago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions and one suggestion regarding changing a var name. Approved!

src/Analysis/GWASV2/Components/Diagrams/CohortsOverlapDiagram/CohortsOverlapDiagram.stories.jsx Show resolved Hide resolved
src/Analysis/GWASV2/Components/Diagrams/PhenotypeHistogram/Histogram.jsx Show resolved Hide resolved
src/Analysis/GWASV2/Components/Diagrams/PhenotypeHistogram/Histogram.stories.jsx Show resolved Hide resolved
src/Analysis/GWASV2/Components/Diagrams/PhenotypeHistogram/PhenotypeHistogram.jsx Show resolved Hide resolved
src/Analysis/GWASV2/Components/Diagrams/PhenotypeHistogram/PhenotypeHistogram.stories.jsx Show resolved Hide resolved
src/Analysis/GWASV2/Components/Diagrams/PhenotypeHistogram/PhenotypeHistogram.stories.jsx Show resolved Hide resolved
@pieterlukasse pieterlukasse merged commit 4b30ac0 into feat/vadc_sprint25 Dec 16, 2022
@pieterlukasse pieterlukasse deleted the feat/add_histogram_for_continuous_covariates branch December 16, 2022 16:21
This was referenced Oct 1, 2023
Open
Open
@BinamB BinamB mentioned this pull request Oct 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarvisraymond-uchicago jarvisraymond-uchicago jarvisraymond-uchicago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pieterlukasse @jarvisraymond-uchicago