feat: get case control population sizes in modal #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarvisraymond-uchicago
requested changes
Dec 16, 2022
There was a problem hiding this comment.
Looks good, I tested locally and it works!
- I had a question about UPDATE_SELECTED_HARE hard coded value
- Should the storybook for the ConfigureGWAS be updated to show both a dichotomous outcome selection and a non-dichotomous outcome selection?
- Had a nitpick about iterator as key that can probably be ignored since the linter doesn't seem to care.
- Ran ESLINT-new to autoformat files, this included changes from Master. Then I updated SPRINT25 to be up-to-date with Master (https://github.com/uc-cdis/data-portal/tree/feat/vadc_sprint25), but these updates are showing as changed files in this PR now. I don't think that's right and I'm not sure why that is occurring.
28fabfb to
77c0bba
Compare
jarvisraymond-uchicago
approved these changes
Dec 16, 2022
...and extra header in storybook to help developer test different scenarios
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: VADC-371
New Features
Screenshot:
