Update node js and fix failing unit tests #1119

pieterlukasse · 2022-10-13T17:57:43Z

Related to Jira Ticket: VADC-59 , VADC-247

Bug Fixes

fixed unhandled promise rejection, which fixes a failing unit test
fixed failing unit test for UserProfile

Improvements

this allows for devs running local node js version > 14 to also get all the tests to pass

Dependency updates

updated node js to 16.x in Dockerfile and Travis CI tests

mfshao

🎉

pieterlukasse · 2022-10-17T13:15:46Z

@mfshao: the labelled tests pass when we update only node js to 16.x and keep npm as is (8.5). I'll rerun all tests now.

...which fixes locally failing jest test

src/Submission/MapDataModel.jsx

* Update node js and fix failing unit tests (#1119) * fixed unhandled promise rejection ...which fixes locally failing jest test * fix failing unit test for UserProfile * udpate node js and npm for CI tests * make test a bit more specific * set node js to 16.x * update node js to 16.x and npm to 8.15 in Dockerfile * revert npm version change * feat(CombineGWASWorkflowProgressBar): Initial commit * feat(CombineGWASWorkflowProgressBar): created partially working prototype * feat(CombineGWASWorkflowProgressBar): added logic for displaying select or edit for each step * feat(CombineGWASWorkflowProgressBar): created CSS style sheet for new component and began overriding AntD styles to match design * feat(CombineGWASWorkflowProgressBar): fixed colors to match design for numeric icons * feat(CombineGWASWorkflowProgressBar): set width to container to 100% * feat(CombineGWASWorkflowProgressBar): added animation * feat(CombineGWASWorkflowProgressBar): added styles for Get Started button * feat(CombineGWASWorkflowProgressBar): positioned get started button * feat(CombineGWASWorkflowProgressBar): removed inline styles from ProgressBar.jsx * feat(CombineGWASWorkflowProgressBar): formatted GWASContainer.jsx * feat(CombineGWASWorkflowProgressBar): changed class name to progress-bar * feat(CombineGWASWorkflowProgressBar): began authoring JEST test * feat(CombineGWASWorkflowProgressBar): Added clarifying comment to jest test * feat(CombineGWASWorkflowProgressBar): Formatted test code * feat(CombineGWASWorkflowProgressBar): Added Story Book for ProgressBar * feat(CombineGWASWorkflowProgressBar): ran eslint on ProgressBar.test.jsx * feat(CombineGWASWorkflowProgressBar): ran autoformatters eslint and stylelint * feat(CombineGWASWorkflowProgressBar): Resolved style lint error in ProgressBar.css * feat(CombineGWASWorkflowProgressBar): Resolved remaining style lint errors in ProgressBar.css * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file Dockerfile * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file Submission/MapDataModel.jsx * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file UserProfile/UserProfile.test.jsx * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file again UserProfile/UserProfile.test.jsx * feat(CombineGWASWorkflowProgressBar): Ran ESLINT fix * feat(CombineGWASWorkflowProgressBar): Refactored code to use a constants file to make code more DRY * feat(CombineGWASWorkflowProgressBar): Ran ESLINT on recently updated files * feat(CombineGWASWorkflowProgressBar): Ran ESLINT on recently updated files * feat(CombineGWASWorkflowProgressBar): Added media query so that button will not overlap progress bar on smaller screens * feat(CombineGWASWorkflowProgressBar): Formatted CSS with line break * feat(CombineGWASWorkflowProgressBar): Updated JEST test to use for loops * feat(CombineGWASWorkflowProgressBar): Updated GWASContainer.jsx to use nextButtonEnabled boolean for disabling or enabling next button * feat(CombineGWASWorkflowProgressBar): Ran eslint on GWASContainer.jsx Co-authored-by: pieterlukasse <pieterlukasse@gmail.com>

* Update node js and fix failing unit tests (#1119) * fixed unhandled promise rejection ...which fixes locally failing jest test * fix failing unit test for UserProfile * udpate node js and npm for CI tests * make test a bit more specific * set node js to 16.x * update node js to 16.x and npm to 8.15 in Dockerfile * revert npm version change * feat(eslintOnlyOnCurrentBranch): Added new command eslint-new * feat(eslintOnlyOnCurrentBranch): Removed ignore pattern for json * feat(eslintOnlyOnCurrentBranch): Reverted files changed in feat/vadc_sprint21 * feat(eslintOnlyOnCurrentBranch): Reverted additional files changed in feat/vadc_sprint21 * feat(eslintOnlyOnCurrentBranch): Updated r eadme.md with info on linting * feat(eslintOnlyOnCurrentBranch): Spell checked and edited new addition to README.md * feat(eslintOnlyOnCurrentBranch): Updated to reference master instead of HEAD * feat(eslintOnlyOnCurrentBranch): Updated command to only parse JS JSX and TSX files and quiet warnings * feat(eslintOnlyOnCurrentBranch): Updated command to use ext from original command, but added additional ignore patterns * feat(eslintOnlyOnCurrentBranch): Updated command to ignore yml files Co-authored-by: pieterlukasse <pieterlukasse@gmail.com>

* Feat/combine gwas workflow progress bar (#1125) * Update node js and fix failing unit tests (#1119) * fixed unhandled promise rejection ...which fixes locally failing jest test * fix failing unit test for UserProfile * udpate node js and npm for CI tests * make test a bit more specific * set node js to 16.x * update node js to 16.x and npm to 8.15 in Dockerfile * revert npm version change * feat(CombineGWASWorkflowProgressBar): Initial commit * feat(CombineGWASWorkflowProgressBar): created partially working prototype * feat(CombineGWASWorkflowProgressBar): added logic for displaying select or edit for each step * feat(CombineGWASWorkflowProgressBar): created CSS style sheet for new component and began overriding AntD styles to match design * feat(CombineGWASWorkflowProgressBar): fixed colors to match design for numeric icons * feat(CombineGWASWorkflowProgressBar): set width to container to 100% * feat(CombineGWASWorkflowProgressBar): added animation * feat(CombineGWASWorkflowProgressBar): added styles for Get Started button * feat(CombineGWASWorkflowProgressBar): positioned get started button * feat(CombineGWASWorkflowProgressBar): removed inline styles from ProgressBar.jsx * feat(CombineGWASWorkflowProgressBar): formatted GWASContainer.jsx * feat(CombineGWASWorkflowProgressBar): changed class name to progress-bar * feat(CombineGWASWorkflowProgressBar): began authoring JEST test * feat(CombineGWASWorkflowProgressBar): Added clarifying comment to jest test * feat(CombineGWASWorkflowProgressBar): Formatted test code * feat(CombineGWASWorkflowProgressBar): Added Story Book for ProgressBar * feat(CombineGWASWorkflowProgressBar): ran eslint on ProgressBar.test.jsx * feat(CombineGWASWorkflowProgressBar): ran autoformatters eslint and stylelint * feat(CombineGWASWorkflowProgressBar): Resolved style lint error in ProgressBar.css * feat(CombineGWASWorkflowProgressBar): Resolved remaining style lint errors in ProgressBar.css * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file Dockerfile * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file Submission/MapDataModel.jsx * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file UserProfile/UserProfile.test.jsx * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file again UserProfile/UserProfile.test.jsx * feat(CombineGWASWorkflowProgressBar): Ran ESLINT fix * feat(CombineGWASWorkflowProgressBar): Refactored code to use a constants file to make code more DRY * feat(CombineGWASWorkflowProgressBar): Ran ESLINT on recently updated files * feat(CombineGWASWorkflowProgressBar): Ran ESLINT on recently updated files * feat(CombineGWASWorkflowProgressBar): Added media query so that button will not overlap progress bar on smaller screens * feat(CombineGWASWorkflowProgressBar): Formatted CSS with line break * feat(CombineGWASWorkflowProgressBar): Updated JEST test to use for loops * feat(CombineGWASWorkflowProgressBar): Updated GWASContainer.jsx to use nextButtonEnabled boolean for disabling or enabling next button * feat(CombineGWASWorkflowProgressBar): Ran eslint on GWASContainer.jsx Co-authored-by: pieterlukasse <pieterlukasse@gmail.com> * feat(CombineGWASWorkflowAttritionTable): Initial Commit, not working yet * feat(CombineGWASWorkflowAttritionTable): Added eslint-new command to this branch * feat(CombineGWASWorkflowProgressBar): Updated file references in AttritionTable imports * feat(CombineGWASWorkflowProgressBar): Created partially working prototype (shows some data, no headers, has js errors) * feat(CombineGWASWorkflowAttritionTable): Added table header obj to constants.js * feat(CombineGWASWorkflowAttritionTable): Added table headerDataSource obj to constants and ran eslint-new * feat(CombineGWASWorkflowAttritionTable): updated tableHeader in GWASContainer.jsx * feat(CombineGWASWorkflowAttritionTable): began styling table * feat(CombineGWASWorkflowAttritionTable): made alternating table rows different colors * feat(CombineGWASWorkflowAttritionTable): added table borders * feat(CombineGWASWorkflowAttritionTable): ran stylelint * feat(CombineGWASWorkflowAttritionTable): created ChartIcons directory and refactored to use more semantic HTML * feat(CombineGWASWorkflowAttritionTable): added SVG icons * feat(CombineGWASWorkflowAttritionTable): Updated dropdown icon styling * feat(CombineGWASWorkflowAttritionTable): Removed unneeded files and updated padding on table * feat(CombineGWASWorkflowAttritionTable): Reset files unrelated to this ticket * feat(CombineGWASWorkflowAttritionTable): Updated dropdown button styles * feat(CombineGWASWorkflowAttritionTable): Updated attrition table logic, styles and storybook to not use antD list component, to avoid injection of non-tabular elements in table element * feat(CombineGWASWorkflowAttritionTable): Converted inline styles to class names * feat(CombineGWASWorkflowAttritionTable): Updated padding left class to 26px * feat(CombineGWASWorkflowAttritionTable): Ran eslint-new on branch and fixed errors * feat(CombineGWASWorkflowAttritionTable): Ran stylelint on branch and fixed errors * feat(CombineGWASWorkflowAttritionTable): Reverted unintentionally changed ProgressBar.test.jsx file * feat(CombineGWASWorkflowsAttritionTable): Made SVG more accessible * feat(CombineGWASWorkflowAttritionTable): Changed title elements to desc to avoid hover effect in browser - additional accessible text will be added once chart fires modal * feat(CombineGWASWorkflowAttritionTable): Removed inline comments in AttritionTableRow.jsx, they've been logged in a ticket instead * feat(CombineGWASWorkflowAttritionTable): Clarified comment in AttritionTableRow.jsx * feat(CombineGWASWorkflowAttritionTable): Made CSS consistent for colors in AttritionTable.css * feat(CombineGWASWorkflowAttritionTable): Created new CSS rule to make stylesheet more DRY * feat(CombineGWASWorkflowsAttritionTable): Cleaned up JS formating in AttritionTable.jsx Co-authored-by: pieterlukasse <pieterlukasse@gmail.com>

* Feat/combine gwas workflow progress bar (#1125) * feat(CombineGWASWorkflowProgressBar): Initial commit * feat(CombineGWASWorkflowProgressBar): created partially working prototype * feat(CombineGWASWorkflowProgressBar): added logic for displaying select or edit for each step * feat(CombineGWASWorkflowProgressBar): created CSS style sheet for new component and began overriding AntD styles to match design * feat(CombineGWASWorkflowProgressBar): fixed colors to match design for numeric icons * feat(CombineGWASWorkflowProgressBar): set width to container to 100% * feat(CombineGWASWorkflowProgressBar): added animation * feat(CombineGWASWorkflowProgressBar): added styles for Get Started button * feat(CombineGWASWorkflowProgressBar): positioned get started button * feat(CombineGWASWorkflowProgressBar): removed inline styles from ProgressBar.jsx * feat(CombineGWASWorkflowProgressBar): formatted GWASContainer.jsx * feat(CombineGWASWorkflowProgressBar): changed class name to progress-bar * feat(CombineGWASWorkflowProgressBar): began authoring JEST test * feat(CombineGWASWorkflowProgressBar): Added clarifying comment to jest test * feat(CombineGWASWorkflowProgressBar): Formatted test code * feat(CombineGWASWorkflowProgressBar): Added Story Book for ProgressBar * feat(CombineGWASWorkflowProgressBar): ran eslint on ProgressBar.test.jsx * feat(CombineGWASWorkflowProgressBar): ran autoformatters eslint and stylelint * feat(CombineGWASWorkflowProgressBar): Resolved style lint error in ProgressBar.css * feat(CombineGWASWorkflowProgressBar): Resolved remaining style lint errors in ProgressBar.css * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file Dockerfile * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file Submission/MapDataModel.jsx * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file UserProfile/UserProfile.test.jsx * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file again UserProfile/UserProfile.test.jsx * feat(CombineGWASWorkflowProgressBar): Ran ESLINT fix * feat(CombineGWASWorkflowProgressBar): Refactored code to use a constants file to make code more DRY * feat(CombineGWASWorkflowProgressBar): Ran ESLINT on recently updated files * feat(CombineGWASWorkflowProgressBar): Ran ESLINT on recently updated files * feat(CombineGWASWorkflowProgressBar): Added media query so that button will not overlap progress bar on smaller screens * feat(CombineGWASWorkflowProgressBar): Formatted CSS with line break * feat(CombineGWASWorkflowProgressBar): Updated JEST test to use for loops * feat(CombineGWASWorkflowProgressBar): Updated GWASContainer.jsx to use nextButtonEnabled boolean for disabling or enabling next button * feat(CombineGWASWorkflowProgressBar): Ran eslint on GWASContainer.jsx * feat(eslintOnlyOnCurrentBranch): Added new command eslint-new (#1128) * feat(eslintOnlyOnCurrentBranch): Added new command eslint-new * feat(eslintOnlyOnCurrentBranch): Removed ignore pattern for json * feat(eslintOnlyOnCurrentBranch): Reverted files changed in feat/vadc_sprint21 * feat(eslintOnlyOnCurrentBranch): Reverted additional files changed in feat/vadc_sprint21 * feat(eslintOnlyOnCurrentBranch): Updated r eadme.md with info on linting * feat(eslintOnlyOnCurrentBranch): Spell checked and edited new addition to README.md * feat(eslintOnlyOnCurrentBranch): Updated to reference master instead of HEAD * feat(eslintOnlyOnCurrentBranch): Updated command to only parse JS JSX and TSX files and quiet warnings * feat(eslintOnlyOnCurrentBranch): Updated command to use ext from original command, but added additional ignore patterns * feat(eslintOnlyOnCurrentBranch): Updated command to ignore yml files * Feat/combine gwas workflow attrition table styling and setup (#1129) * Feat/combine gwas workflow progress bar (#1125) * Update node js and fix failing unit tests (#1119) * fixed unhandled promise rejection ...which fixes locally failing jest test * fix failing unit test for UserProfile * udpate node js and npm for CI tests * make test a bit more specific * set node js to 16.x * update node js to 16.x and npm to 8.15 in Dockerfile * revert npm version change * feat(CombineGWASWorkflowProgressBar): Initial commit * feat(CombineGWASWorkflowProgressBar): created partially working prototype * feat(CombineGWASWorkflowProgressBar): added logic for displaying select or edit for each step * feat(CombineGWASWorkflowProgressBar): created CSS style sheet for new component and began overriding AntD styles to match design * feat(CombineGWASWorkflowProgressBar): fixed colors to match design for numeric icons * feat(CombineGWASWorkflowProgressBar): set width to container to 100% * feat(CombineGWASWorkflowProgressBar): added animation * feat(CombineGWASWorkflowProgressBar): added styles for Get Started button * feat(CombineGWASWorkflowProgressBar): positioned get started button * feat(CombineGWASWorkflowProgressBar): removed inline styles from ProgressBar.jsx * feat(CombineGWASWorkflowProgressBar): formatted GWASContainer.jsx * feat(CombineGWASWorkflowProgressBar): changed class name to progress-bar * feat(CombineGWASWorkflowProgressBar): began authoring JEST test * feat(CombineGWASWorkflowProgressBar): Added clarifying comment to jest test * feat(CombineGWASWorkflowProgressBar): Formatted test code * feat(CombineGWASWorkflowProgressBar): Added Story Book for ProgressBar * feat(CombineGWASWorkflowProgressBar): ran eslint on ProgressBar.test.jsx * feat(CombineGWASWorkflowProgressBar): ran autoformatters eslint and stylelint * feat(CombineGWASWorkflowProgressBar): Resolved style lint error in ProgressBar.css * feat(CombineGWASWorkflowProgressBar): Resolved remaining style lint errors in ProgressBar.css * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file Dockerfile * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file Submission/MapDataModel.jsx * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file UserProfile/UserProfile.test.jsx * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file again UserProfile/UserProfile.test.jsx * feat(CombineGWASWorkflowProgressBar): Ran ESLINT fix * feat(CombineGWASWorkflowProgressBar): Refactored code to use a constants file to make code more DRY * feat(CombineGWASWorkflowProgressBar): Ran ESLINT on recently updated files * feat(CombineGWASWorkflowProgressBar): Ran ESLINT on recently updated files * feat(CombineGWASWorkflowProgressBar): Added media query so that button will not overlap progress bar on smaller screens * feat(CombineGWASWorkflowProgressBar): Formatted CSS with line break * feat(CombineGWASWorkflowProgressBar): Updated JEST test to use for loops * feat(CombineGWASWorkflowProgressBar): Updated GWASContainer.jsx to use nextButtonEnabled boolean for disabling or enabling next button * feat(CombineGWASWorkflowProgressBar): Ran eslint on GWASContainer.jsx Co-authored-by: pieterlukasse <pieterlukasse@gmail.com> * feat(CombineGWASWorkflowAttritionTable): Initial Commit, not working yet * feat(CombineGWASWorkflowAttritionTable): Added eslint-new command to this branch * feat(CombineGWASWorkflowProgressBar): Updated file references in AttritionTable imports * feat(CombineGWASWorkflowProgressBar): Created partially working prototype (shows some data, no headers, has js errors) * feat(CombineGWASWorkflowAttritionTable): Added table header obj to constants.js * feat(CombineGWASWorkflowAttritionTable): Added table headerDataSource obj to constants and ran eslint-new * feat(CombineGWASWorkflowAttritionTable): updated tableHeader in GWASContainer.jsx * feat(CombineGWASWorkflowAttritionTable): began styling table * feat(CombineGWASWorkflowAttritionTable): made alternating table rows different colors * feat(CombineGWASWorkflowAttritionTable): added table borders * feat(CombineGWASWorkflowAttritionTable): ran stylelint * feat(CombineGWASWorkflowAttritionTable): created ChartIcons directory and refactored to use more semantic HTML * feat(CombineGWASWorkflowAttritionTable): added SVG icons * feat(CombineGWASWorkflowAttritionTable): Updated dropdown icon styling * feat(CombineGWASWorkflowAttritionTable): Removed unneeded files and updated padding on table * feat(CombineGWASWorkflowAttritionTable): Reset files unrelated to this ticket * feat(CombineGWASWorkflowAttritionTable): Updated dropdown button styles * feat(CombineGWASWorkflowAttritionTable): Updated attrition table logic, styles and storybook to not use antD list component, to avoid injection of non-tabular elements in table element * feat(CombineGWASWorkflowAttritionTable): Converted inline styles to class names * feat(CombineGWASWorkflowAttritionTable): Updated padding left class to 26px * feat(CombineGWASWorkflowAttritionTable): Ran eslint-new on branch and fixed errors * feat(CombineGWASWorkflowAttritionTable): Ran stylelint on branch and fixed errors * feat(CombineGWASWorkflowAttritionTable): Reverted unintentionally changed ProgressBar.test.jsx file * feat(CombineGWASWorkflowsAttritionTable): Made SVG more accessible * feat(CombineGWASWorkflowAttritionTable): Changed title elements to desc to avoid hover effect in browser - additional accessible text will be added once chart fires modal * feat(CombineGWASWorkflowAttritionTable): Removed inline comments in AttritionTableRow.jsx, they've been logged in a ticket instead * feat(CombineGWASWorkflowAttritionTable): Clarified comment in AttritionTableRow.jsx * feat(CombineGWASWorkflowAttritionTable): Made CSS consistent for colors in AttritionTable.css * feat(CombineGWASWorkflowAttritionTable): Created new CSS rule to make stylesheet more DRY * feat(CombineGWASWorkflowsAttritionTable): Cleaned up JS formating in AttritionTable.jsx Co-authored-by: pieterlukasse <pieterlukasse@gmail.com> * chore(euler/venn): add "@upsetjs/venn.js": "^1.4.2" * feat(euler/venn): add simple euler diagram component - uses venn.js and queries cohorts and cohort overlap endpoint * chore(euler/venn): pin uglify-js and ansi-regex ...shoud solve snyk issue * feat(vadc_sprint21): Removed console.log statements from CohortsOverlapDiagram.stories.jsx * feat(vadc_sprint21): Removed console logs from AttritionTable.stories.jsx Co-authored-by: pieterlukasse <pieterlukasse@gmail.com>

* fixed unhandled promise rejection ...which fixes locally failing jest test * fix failing unit test for UserProfile * udpate node js and npm for CI tests * make test a bit more specific * set node js to 16.x * update node js to 16.x and npm to 8.15 in Dockerfile * revert npm version change

* Feat/combine gwas workflow progress bar (#1125) * feat(CombineGWASWorkflowProgressBar): Initial commit * feat(CombineGWASWorkflowProgressBar): created partially working prototype * feat(CombineGWASWorkflowProgressBar): added logic for displaying select or edit for each step * feat(CombineGWASWorkflowProgressBar): created CSS style sheet for new component and began overriding AntD styles to match design * feat(CombineGWASWorkflowProgressBar): fixed colors to match design for numeric icons * feat(CombineGWASWorkflowProgressBar): set width to container to 100% * feat(CombineGWASWorkflowProgressBar): added animation * feat(CombineGWASWorkflowProgressBar): added styles for Get Started button * feat(CombineGWASWorkflowProgressBar): positioned get started button * feat(CombineGWASWorkflowProgressBar): removed inline styles from ProgressBar.jsx * feat(CombineGWASWorkflowProgressBar): formatted GWASContainer.jsx * feat(CombineGWASWorkflowProgressBar): changed class name to progress-bar * feat(CombineGWASWorkflowProgressBar): began authoring JEST test * feat(CombineGWASWorkflowProgressBar): Added clarifying comment to jest test * feat(CombineGWASWorkflowProgressBar): Formatted test code * feat(CombineGWASWorkflowProgressBar): Added Story Book for ProgressBar * feat(CombineGWASWorkflowProgressBar): ran eslint on ProgressBar.test.jsx * feat(CombineGWASWorkflowProgressBar): ran autoformatters eslint and stylelint * feat(CombineGWASWorkflowProgressBar): Resolved style lint error in ProgressBar.css * feat(CombineGWASWorkflowProgressBar): Resolved remaining style lint errors in ProgressBar.css * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file Dockerfile * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file Submission/MapDataModel.jsx * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file UserProfile/UserProfile.test.jsx * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file again UserProfile/UserProfile.test.jsx * feat(CombineGWASWorkflowProgressBar): Ran ESLINT fix * feat(CombineGWASWorkflowProgressBar): Refactored code to use a constants file to make code more DRY * feat(CombineGWASWorkflowProgressBar): Ran ESLINT on recently updated files * feat(CombineGWASWorkflowProgressBar): Ran ESLINT on recently updated files * feat(CombineGWASWorkflowProgressBar): Added media query so that button will not overlap progress bar on smaller screens * feat(CombineGWASWorkflowProgressBar): Formatted CSS with line break * feat(CombineGWASWorkflowProgressBar): Updated JEST test to use for loops * feat(CombineGWASWorkflowProgressBar): Updated GWASContainer.jsx to use nextButtonEnabled boolean for disabling or enabling next button * feat(CombineGWASWorkflowProgressBar): Ran eslint on GWASContainer.jsx * feat(eslintOnlyOnCurrentBranch): Added new command eslint-new (#1128) * feat(eslintOnlyOnCurrentBranch): Added new command eslint-new * feat(eslintOnlyOnCurrentBranch): Removed ignore pattern for json * feat(eslintOnlyOnCurrentBranch): Reverted files changed in feat/vadc_sprint21 * feat(eslintOnlyOnCurrentBranch): Reverted additional files changed in feat/vadc_sprint21 * feat(eslintOnlyOnCurrentBranch): Updated r eadme.md with info on linting * feat(eslintOnlyOnCurrentBranch): Spell checked and edited new addition to README.md * feat(eslintOnlyOnCurrentBranch): Updated to reference master instead of HEAD * feat(eslintOnlyOnCurrentBranch): Updated command to only parse JS JSX and TSX files and quiet warnings * feat(eslintOnlyOnCurrentBranch): Updated command to use ext from original command, but added additional ignore patterns * feat(eslintOnlyOnCurrentBranch): Updated command to ignore yml files * Feat/combine gwas workflow attrition table styling and setup (#1129) * Feat/combine gwas workflow progress bar (#1125) * Update node js and fix failing unit tests (#1119) * fixed unhandled promise rejection ...which fixes locally failing jest test * fix failing unit test for UserProfile * udpate node js and npm for CI tests * make test a bit more specific * set node js to 16.x * update node js to 16.x and npm to 8.15 in Dockerfile * revert npm version change * feat(CombineGWASWorkflowProgressBar): Initial commit * feat(CombineGWASWorkflowProgressBar): created partially working prototype * feat(CombineGWASWorkflowProgressBar): added logic for displaying select or edit for each step * feat(CombineGWASWorkflowProgressBar): created CSS style sheet for new component and began overriding AntD styles to match design * feat(CombineGWASWorkflowProgressBar): fixed colors to match design for numeric icons * feat(CombineGWASWorkflowProgressBar): set width to container to 100% * feat(CombineGWASWorkflowProgressBar): added animation * feat(CombineGWASWorkflowProgressBar): added styles for Get Started button * feat(CombineGWASWorkflowProgressBar): positioned get started button * feat(CombineGWASWorkflowProgressBar): removed inline styles from ProgressBar.jsx * feat(CombineGWASWorkflowProgressBar): formatted GWASContainer.jsx * feat(CombineGWASWorkflowProgressBar): changed class name to progress-bar * feat(CombineGWASWorkflowProgressBar): began authoring JEST test * feat(CombineGWASWorkflowProgressBar): Added clarifying comment to jest test * feat(CombineGWASWorkflowProgressBar): Formatted test code * feat(CombineGWASWorkflowProgressBar): Added Story Book for ProgressBar * feat(CombineGWASWorkflowProgressBar): ran eslint on ProgressBar.test.jsx * feat(CombineGWASWorkflowProgressBar): ran autoformatters eslint and stylelint * feat(CombineGWASWorkflowProgressBar): Resolved style lint error in ProgressBar.css * feat(CombineGWASWorkflowProgressBar): Resolved remaining style lint errors in ProgressBar.css * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file Dockerfile * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file Submission/MapDataModel.jsx * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file UserProfile/UserProfile.test.jsx * feat(CombineGWASWorkflowProgressBar): reverted unintentionally changed file again UserProfile/UserProfile.test.jsx * feat(CombineGWASWorkflowProgressBar): Ran ESLINT fix * feat(CombineGWASWorkflowProgressBar): Refactored code to use a constants file to make code more DRY * feat(CombineGWASWorkflowProgressBar): Ran ESLINT on recently updated files * feat(CombineGWASWorkflowProgressBar): Ran ESLINT on recently updated files * feat(CombineGWASWorkflowProgressBar): Added media query so that button will not overlap progress bar on smaller screens * feat(CombineGWASWorkflowProgressBar): Formatted CSS with line break * feat(CombineGWASWorkflowProgressBar): Updated JEST test to use for loops * feat(CombineGWASWorkflowProgressBar): Updated GWASContainer.jsx to use nextButtonEnabled boolean for disabling or enabling next button * feat(CombineGWASWorkflowProgressBar): Ran eslint on GWASContainer.jsx Co-authored-by: pieterlukasse <pieterlukasse@gmail.com> * feat(CombineGWASWorkflowAttritionTable): Initial Commit, not working yet * feat(CombineGWASWorkflowAttritionTable): Added eslint-new command to this branch * feat(CombineGWASWorkflowProgressBar): Updated file references in AttritionTable imports * feat(CombineGWASWorkflowProgressBar): Created partially working prototype (shows some data, no headers, has js errors) * feat(CombineGWASWorkflowAttritionTable): Added table header obj to constants.js * feat(CombineGWASWorkflowAttritionTable): Added table headerDataSource obj to constants and ran eslint-new * feat(CombineGWASWorkflowAttritionTable): updated tableHeader in GWASContainer.jsx * feat(CombineGWASWorkflowAttritionTable): began styling table * feat(CombineGWASWorkflowAttritionTable): made alternating table rows different colors * feat(CombineGWASWorkflowAttritionTable): added table borders * feat(CombineGWASWorkflowAttritionTable): ran stylelint * feat(CombineGWASWorkflowAttritionTable): created ChartIcons directory and refactored to use more semantic HTML * feat(CombineGWASWorkflowAttritionTable): added SVG icons * feat(CombineGWASWorkflowAttritionTable): Updated dropdown icon styling * feat(CombineGWASWorkflowAttritionTable): Removed unneeded files and updated padding on table * feat(CombineGWASWorkflowAttritionTable): Reset files unrelated to this ticket * feat(CombineGWASWorkflowAttritionTable): Updated dropdown button styles * feat(CombineGWASWorkflowAttritionTable): Updated attrition table logic, styles and storybook to not use antD list component, to avoid injection of non-tabular elements in table element * feat(CombineGWASWorkflowAttritionTable): Converted inline styles to class names * feat(CombineGWASWorkflowAttritionTable): Updated padding left class to 26px * feat(CombineGWASWorkflowAttritionTable): Ran eslint-new on branch and fixed errors * feat(CombineGWASWorkflowAttritionTable): Ran stylelint on branch and fixed errors * feat(CombineGWASWorkflowAttritionTable): Reverted unintentionally changed ProgressBar.test.jsx file * feat(CombineGWASWorkflowsAttritionTable): Made SVG more accessible * feat(CombineGWASWorkflowAttritionTable): Changed title elements to desc to avoid hover effect in browser - additional accessible text will be added once chart fires modal * feat(CombineGWASWorkflowAttritionTable): Removed inline comments in AttritionTableRow.jsx, they've been logged in a ticket instead * feat(CombineGWASWorkflowAttritionTable): Clarified comment in AttritionTableRow.jsx * feat(CombineGWASWorkflowAttritionTable): Made CSS consistent for colors in AttritionTable.css * feat(CombineGWASWorkflowAttritionTable): Created new CSS rule to make stylesheet more DRY * feat(CombineGWASWorkflowsAttritionTable): Cleaned up JS formating in AttritionTable.jsx Co-authored-by: pieterlukasse <pieterlukasse@gmail.com> * chore(euler/venn): add "@upsetjs/venn.js": "^1.4.2" * feat(euler/venn): add simple euler diagram component - uses venn.js and queries cohorts and cohort overlap endpoint * chore(euler/venn): pin uglify-js and ansi-regex ...shoud solve snyk issue * feat(vadc_sprint21): Removed console.log statements from CohortsOverlapDiagram.stories.jsx * feat(vadc_sprint21): Removed console logs from AttritionTable.stories.jsx Co-authored-by: pieterlukasse <pieterlukasse@gmail.com>

pieterlukasse requested a review from mfshao October 13, 2022 17:58

pieterlukasse force-pushed the fix_unit_tests_jest branch from 83e4050 to 14e88b6 Compare October 13, 2022 19:09

pieterlukasse changed the title ~~Fix unit tests jest~~ Update node js and npm and fix failing unit tests Oct 13, 2022

mfshao previously approved these changes Oct 13, 2022

View reviewed changes

PlanXCyborg added test-apis-etlTest test-portal-dataUploadTest labels Oct 14, 2022

haraprasadj added jenkins-niaid and removed test-portal-dataUploadTest labels Oct 14, 2022

pieterlukasse added the test-portal-dataUploadTest label Oct 14, 2022

pieterlukasse dismissed mfshao’s stale review via c93a881 October 14, 2022 19:50

pieterlukasse changed the title ~~Update node js and npm and fix failing unit tests~~ Update node js and fix failing unit tests Oct 14, 2022

pieterlukasse removed test-portal-dataUploadTest test-apis-etlTest labels Oct 17, 2022

pieterlukasse added 7 commits October 17, 2022 15:18

fixed unhandled promise rejection

643029c

...which fixes locally failing jest test

fix failing unit test for UserProfile

f9f6956

udpate node js and npm for CI tests

dedd240

make test a bit more specific

984a4a2

set node js to 16.x

b22b282

update node js to 16.x and npm to 8.15 in Dockerfile

04caff7

revert npm version change

deaa26a

pieterlukasse force-pushed the fix_unit_tests_jest branch from c93a881 to deaa26a Compare October 17, 2022 13:19

pieterlukasse commented Oct 17, 2022

View reviewed changes

src/Submission/MapDataModel.jsx Show resolved Hide resolved

Merge branch 'master' into fix_unit_tests_jest

57d5a74

mfshao approved these changes Oct 17, 2022

View reviewed changes

pieterlukasse merged commit b371bcf into master Oct 18, 2022

pieterlukasse deleted the fix_unit_tests_jest branch October 18, 2022 14:15

cstephanos mentioned this pull request Nov 4, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#83

Open

urvi-occ mentioned this pull request Nov 4, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#84

Open

pmartinov mentioned this pull request Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#85

Open

cstephanos mentioned this pull request Nov 5, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#86

Open

urvi-occ mentioned this pull request Dec 25, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#97

Open

This was referenced Dec 25, 2022

[Snyk] Fix for 1 vulnerabilities #1192

Closed

[Snyk] Fix for 1 vulnerabilities #1193

Closed

cstephanos mentioned this pull request Dec 25, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#98

Open

snyk-bot mentioned this pull request Dec 25, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#99

Open

cstephanos mentioned this pull request Dec 26, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#100

Open

Mikisha10 mentioned this pull request Dec 26, 2022

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#101

Open

pmartinov mentioned this pull request Jun 20, 2023

[Snyk] Security upgrade css-loader from 3.6.0 to 4.0.0 occ-data/data-portal#111

Open

paulineribeyre mentioned this pull request Jun 20, 2023

[Snyk] Security upgrade css-loader from 3.6.0 to 4.0.0 #1338

Merged

m0nhawk mentioned this pull request Jun 20, 2023

[Snyk] Fix for 1 vulnerabilities #1339

Closed

urvi-occ mentioned this pull request Jun 21, 2023

[Snyk] Fix for 1 vulnerabilities occ-data/data-portal#113

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update node js and fix failing unit tests #1119

Update node js and fix failing unit tests #1119

pieterlukasse commented Oct 13, 2022 •

edited

Loading

mfshao left a comment

pieterlukasse commented Oct 17, 2022 •

edited

Loading

Update node js and fix failing unit tests #1119

Update node js and fix failing unit tests #1119

Conversation

pieterlukasse commented Oct 13, 2022 • edited Loading

Bug Fixes

Improvements

Dependency updates

mfshao left a comment

Choose a reason for hiding this comment

pieterlukasse commented Oct 17, 2022 • edited Loading

pieterlukasse commented Oct 13, 2022 •

edited

Loading

pieterlukasse commented Oct 17, 2022 •

edited

Loading